Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkgs/bazel*: Fix path to update-srcDeps.py #81512

Merged
merged 1 commit into from Mar 2, 2020
Merged

pkgs/bazel*: Fix path to update-srcDeps.py #81512

merged 1 commit into from Mar 2, 2020

Conversation

dasJ
Copy link
Member

@dasJ dasJ commented Mar 2, 2020

Otherwise, the -small channel fails on the tarball output.

Motivation for this change

The -small jobset fails.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dasJ
pkgs/bazel*: Fix path to update-srcDeps.py
0723bf3 
Otherwise, the -small channel fails on the tarball output.
@dasJ dasJ requested a review from Profpatsch as a code owner March 2, 2020 12:12
@vcunat vcunat added the 1.severity: channel blocker Blocks a channel label Mar 2, 2020
@vcunat vcunat self-assigned this Mar 2, 2020
vcunat
vcunat approved these changes Mar 2, 2020
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ Seems fine; I just re-tested the tarball job.

@vcunat vcunat merged commit a2afee9 into NixOS:master Mar 2, 2020
@dasJ dasJ deleted the fix-bazel-build branch March 2, 2020 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@Profpatsch Profpatsch Awaiting requested review from Profpatsch Profpatsch is a code owner

Assignees

@vcunat vcunat

Labels
1.severity: channel blocker Blocks a channel 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dasJ @vcunat