Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] pkgs/bazel*: Fix path to update-srcDeps.py #81513

Closed
wants to merge 1 commit into from
Closed

[20.03] pkgs/bazel*: Fix path to update-srcDeps.py #81513

wants to merge 1 commit into from

Conversation

dasJ
Copy link
Member

@dasJ dasJ commented Mar 2, 2020

Motivation for this change

The -small jobset fails.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dasJ dasJ changed the base branch from master to release-20.03 March 2, 2020 12:15
@dasJ
Copy link
Member Author

dasJ commented Mar 2, 2020

Sorry for all these review requests, I picked the wrong merge base :/

@dasJ dasJ force-pushed the bp-fix-bazel-build branch 2 times, most recently from d5dde79 to 71e17ae Compare March 2, 2020 13:41
@dasJ
pkgs/bazel*: Fix path to update-srcDeps.py
8a56611 
Otherwise, the -small channel fails on the tarball output.

(cherry picked from commit 0723bf3)
@FRidh
Copy link
Member

FRidh commented Mar 2, 2020

This should go via master first.

@Profpatsch
Copy link
Member

Was merged on master

@FRidh
Copy link
Member

FRidh commented Mar 2, 2020

I just pushed this directly to 20.03.

@FRidh FRidh closed this Mar 2, 2020
@dasJ dasJ deleted the bp-fix-bazel-build branch March 2, 2020 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssais alyssais Awaiting requested review from alyssais

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@etu etu Awaiting requested review from etu

@FRidh FRidh Awaiting requested review from FRidh

@infinisil infinisil Awaiting requested review from infinisil

@jonringer jonringer Awaiting requested review from jonringer

@LnL7 LnL7 Awaiting requested review from LnL7

@Mic92 Mic92 Awaiting requested review from Mic92

@peti peti Awaiting requested review from peti

@Profpatsch Profpatsch Awaiting requested review from Profpatsch Profpatsch is a code owner

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@ttuegel ttuegel Awaiting requested review from ttuegel

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dasJ @FRidh @Profpatsch