gitlab: 12.7.6 -> 12.8.1 #81556
Merged
gitlab: 12.7.6 -> 12.8.1 #81556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg test gitlab |
ofborg
bot
added
11.by: package-maintainer
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
labels
ghost
reviewed
Mar 3, 2020
ghost
reviewed
Mar 3, 2020
ghost
approved these changes
Mar 3, 2020
In order to build gitaly, this locally overrides the version of libgit2, since gitaly is not compatible with the latest version.
This is left over from when gitlab-shell had a ruby part and a go part. The ruby part is now gone, so let's call the go part gitlab-shell.
The way ruby loads gems and keeps track of their paths seems to not always work very well when the gems are accessed through symlinks. Ruby will then complain that the same files are loaded multiple times; it relies on the file's full path to determine whether the file is loaded or not. This adds an option to simply copy all gem files into the environment instead, which gets rid of this issue, but may instead result in major file duplication.
This fixes issue NixOS#79374, where gitaly prints warning messages on the client side when running push or fetch.
|
I just added a fix for #79374. It touches the @GrahamcOfBorg test gitlab |
|
I deployed the new version and can confirm it fixes #79374 too. Thanks! |
flokli
approved these changes
Mar 3, 2020
|
I also ran nix-review to make sure the changes do bundlerEnv do not create problems for other ruby applications. |
ghost
merged commit
This was referenced Mar 3, 2020
Closed
This was referenced Mar 3, 2020
Closed
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update GitLab to the latest version.
https://about.gitlab.com/releases/2020/02/22/gitlab-12-8-released/
https://about.gitlab.com/releases/2020/02/24/gitlab-12-8-1-released/
This is basically #81057 with fixes and minor additions. I can't add anything to that PR, so I opened this instead.
This still suffers from #79374.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)