Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snippetpixie: 1.2.2 -> 1.3.1 #81554

Merged
merged 1 commit into from Mar 3, 2020

Conversation

ianmjones
Copy link
Member

@ianmjones ianmjones commented Mar 2, 2020

Motivation for this change

Updated to latest version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

Also ran nixfmt for consistent formatting of future changes.

This is more for general nix code, the style the package had before was formatting specific for expressions in nixpkgs https://github.com/nix-community/nixpkgs-fmt. I'd prefer if you reverted it.

@ianmjones
Copy link
Member Author

Also ran nixfmt for consistent formatting of future changes.

This is more for general nix code, the style the package had before was formatting specific for expressions in nixpkgs https://github.com/nix-community/nixpkgs-fmt. I'd prefer if you reverted it.

Sorry about that, did not know there are two styles in play. I've completely reverted formatting changes and ran nixpkgs-fmt over the file to ensure it conforms to nixpkgs standards.

@worldofpeace
Copy link
Contributor

over the file to ensure it conforms to nixpkgs standards.

Uhnn, we don't have anything really official for this yet... So you can imagine some sort of impending code style battle 🤣 (hopefully not)
Myself and my collaborators feel strongly about that style being best aligned for nixpkgs, so I recommend it as much as possible.

@worldofpeace
Copy link
Contributor

It seems you using wnck makes this not work with wayland. Guess that's reworking to do in the future.

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@worldofpeace worldofpeace merged commit 1bb8a2b into NixOS:master Mar 3, 2020
@ianmjones
Copy link
Member Author

It seems you using wnck makes this not work with wayland. Guess that's reworking to do in the future.

Yeah, it's a pain, needed more robust window activation notifications to be able to implement the new trigger key checking for apps that aren't very accessibility savvy, hope to find a better solution in the future.

Thanks for the PR review @worldofpeace, much appreciated.

@ianmjones ianmjones deleted the snippetpixie-update-1.3.1 branch March 3, 2020 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants