Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resilio: fix loaOf deprecation warning #81534

Merged
merged 1 commit into from Mar 19, 2020
Merged

resilio: fix loaOf deprecation warning #81534

merged 1 commit into from Mar 19, 2020

Conversation

yesbox
Copy link
Contributor

@yesbox yesbox commented Mar 2, 2020 •
edited

Fixes the warning on nixos-rebuild when the resilio service is enabled:

trace: warning: In file nixos/modules/services/networking/resilio.nix
a list is being assigned to the option config.users.groups.
This will soon be an error as type loaOf is deprecated.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@yesbox yesbox changed the title resilio: fix a list being assigned to the option config.users.groups resilio: fix loaOf deprecation warning Mar 2, 2020
@yesbox
Copy link
Contributor Author

yesbox commented Mar 15, 2020

Ping @domenkozar @thoughtpolice @cwoac

@thoughtpolice thoughtpolice merged commit 02c2c86 into NixOS:master Mar 19, 2020
@yesbox yesbox deleted the resilio_groups_list branch March 22, 2020 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice thoughtpolice approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yesbox @thoughtpolice