Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rss-bridge: init at 2020-02-26 #81467

Merged
merged 2 commits into from Aug 18, 2020
Merged

rss-bridge: init at 2020-02-26 #81467

merged 2 commits into from Aug 18, 2020

Conversation

dawidsowa
Copy link
Contributor

Motivation for this change

Add rss-bridge.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer reviewed Mar 2, 2020
View reviewed changes
pkgs/servers/web-apps/rss-bridge/default.nix
@@ -0,0 +1,31 @@
{ config, lib, pkgs, fetchFromGitHub, stdenv, ... }:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{ config, lib, pkgs, fetchFromGitHub, stdenv, ... }:
{ config, lib, pkgs, fetchFromGitHub, stdenv, ... }:

@dawidsowa dawidsowa force-pushed the rss-bridge branch 3 times, most recently from 747a0d9 to 45b0d7b Compare March 8, 2020 19:06
@jonringer
Copy link
Contributor

@infinisil do you mind taking a loot at the module?

@jonringer
Copy link
Contributor

also, how can we test this?

@Nadrieril
Copy link
Contributor

FWIW, I tested this and it works

infinisil
infinisil approved these changes Aug 10, 2020
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the platform missing, this looks good to me and is ready to merge!

pkgs/servers/web-apps/rss-bridge/default.nix
description = "The RSS feed for websites missing it";
homepage = "https://github.com/RSS-Bridge/rss-bridge";
license = licenses.unlicense;
maintainers = with maintainers; [ dawidsowa ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

platforms is missing

@infinisil infinisil merged commit 7db9fd1 into NixOS:master Aug 18, 2020
@dawidsowa dawidsowa deleted the rss-bridge branch October 11, 2020 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@infinisil infinisil infinisil approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dawidsowa @jonringer @Nadrieril @infinisil