Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zoom-us: add qtgraphicaleffects dependency #81457

Merged
merged 1 commit into from Mar 4, 2020
Merged

zoom-us: add qtgraphicaleffects dependency #81457

merged 1 commit into from Mar 4, 2020

Conversation

lovesegfault
Copy link
Member

Motivation for this change

I noticed this dep was missing looking at the application logs

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from danbst and tadfisher March 1, 2020 19:32
tadfisher
tadfisher approved these changes Mar 2, 2020
View reviewed changes
Copy link
Contributor

@tadfisher tadfisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍, I don't believe this will hurt, at least.

@worldofpeace worldofpeace merged commit 75f9212 into NixOS:master Mar 4, 2020
@worldofpeace
Copy link
Contributor

Backport needed?

@lovesegfault lovesegfault deleted the zoom-qtdep branch April 7, 2020 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadfisher tadfisher tadfisher approved these changes

@danbst danbst Awaiting requested review from danbst

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lovesegfault @worldofpeace @tadfisher