Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

starship: 0.36.1 -> 0.37.0 #81528

Merged
merged 1 commit into from Mar 2, 2020
Merged

starship: 0.36.1 -> 0.37.0 #81528

merged 1 commit into from Mar 2, 2020

Conversation

davidtwco
Copy link
Member

Motivation for this change

Starship 0.37.0 has been released.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@davidtwco
starship: 0.36.1 -> 0.37.0
11ef2de 
Signed-off-by: David Wood <david@davidtw.co>
@ofborg ofborg bot requested review from bbigras and Br1ght0ne March 2, 2020 14:56
bbigras
bbigras approved these changes Mar 2, 2020
View reviewed changes
Copy link
Contributor

@bbigras bbigras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

builds and runs fine 👍 thanks!

@teto teto merged commit f4d6ed2 into NixOS:master Mar 2, 2020
@davidtwco davidtwco deleted the starship-0.37.0 branch March 31, 2020 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbigras bbigras bbigras approved these changes

@Br1ght0ne Br1ght0ne Br1ght0ne approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@davidtwco @bbigras @Br1ght0ne @teto