Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minecraft-launcher: fix broken url #81450

Closed
wants to merge 1 commit into from
Closed

Conversation

kwannoel
Copy link

@kwannoel kwannoel commented Mar 1, 2020

Motivation for this change

The current url is a dead link, unable to fetch from that source.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
      Able to compile and start the minecraft-launcher binary & play minecraft
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
    Able to compile and start the minecraft-launcher binary & play minecraft
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

cc @hyperfekt

@infinisil
Copy link
Member

The link works for me:

nix-build -A minecraft.src --check
checking outputs of '/nix/store/cxb0ms2b7f1zgncd5hzz3cr4q5g75vx5-minecraft-launcher_2.1.11314.tar.gz.drv'...

trying https://launcher.mojang.com/download/linux/x86_64/minecraft-launcher_2.1.11314.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 70.2M  100 70.2M    0     0  4507k      0  0:00:15  0:00:15 --:--:-- 5353k
/nix/store/83csm2m15w4bncrw0g2ziakgcdby86mp-minecraft-launcher_2.1.11314.tar.gz

@kwannoel kwannoel closed this Mar 2, 2020
@jacereda
Copy link
Contributor

Could this be backported to 19.09?

@jacereda
Copy link
Contributor

Oh sorry, didn't realize it wasn't merged. I can't download from the current URL, I'll try to figure out why.

@kwannoel
Copy link
Author

kwannoel commented Mar 19, 2020

Oh sorry, didn't realize it wasn't merged. I can't download from the current URL, I'll try to figure out why.

When it didnt work I used this as a workaround to pull the latest tarball, this may help @jacereda :

{ config, lib, pkgs, ... }:

let minecraft = pkgs.minecraft.overrideAttrs (oldAttrs: rec {
    version = "0.0.0.0";
    src = builtins.fetchurl {
      url = "https://launcher.mojang.com/download/Minecraft.tar.gz";
      sha256 = "1cd0mpxqmci3m3y1xh5nbx68z69v0x1jyzc07siwfbxqkrlrddj9";
    };
    });

  in { environment.systemPackages = [ minecraft ]; }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants