Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.aria2p: inherit poetry from python-modules #81548

Merged
merged 2 commits into from Mar 2, 2020
Merged

pythonPackages.aria2p: inherit poetry from python-modules #81548

merged 2 commits into from Mar 2, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Mar 2, 2020 •
edited

Motivation for this change

noticed failure reviewing #81536

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
[4 built, 21 copied (3.1 MiB), 0.6 MiB DL]
https://github.com/NixOS/nixpkgs/pull/81548
5 package built:
python27Packages.poetry python37Packages.aria2p python37Packages.poetry python38Packages.aria2p python38Packages.poetry

@jonringer jonringer requested a review from FRidh as a code owner March 2, 2020 17:59
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python38Packages.aria2p

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python27Packages.poetry python37Packages.aria2p python37Packages.poetry python38Packages.aria2p python38Packages.poetry

@jonringer jonringer changed the title pythonPackages.aria2: inherit poetry from python-modules pythonPackages.aria2p: inherit poetry from python-modules Mar 2, 2020
@ofborg ofborg bot requested a review from jbaum98 March 2, 2020 18:24
@jonringer jonringer merged commit 725dc74 into NixOS:master Mar 2, 2020
@jonringer jonringer deleted the fix-aria2-python38 branch March 2, 2020 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jbaum98 jbaum98 Awaiting requested review from jbaum98

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonringer