Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

orca-c: init at git-2020-02-12 #81547

Merged
merged 3 commits into from May 4, 2020
Merged

orca-c: init at git-2020-02-12 #81547

merged 3 commits into from May 4, 2020

Conversation

Sohalt
Copy link
Contributor

@Sohalt Sohalt commented Mar 2, 2020 •
edited

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@grahamc
Copy link
Member

grahamc commented Apr 4, 2020

@GrahamcOfBorg eval

ehmry
ehmry requested changes May 4, 2020
View reviewed changes
pkgs/applications/audio/orca-c/default.nix Outdated
'';

meta = with stdenv.lib; {
description = "Orca is an esoteric programming language designed to quickly create procedural sequencers.";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description must not start with the name of the package.

pkgs/applications/audio/orca-c/default.nix

meta = with stdenv.lib; {
description = "Orca is an esoteric programming language designed to quickly create procedural sequencers.";
homepage = "https://github.com/hundredrabbits/Orca-c";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: homepage is https://wiki.xxiivv.com/site/orca.html?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's only the homepage for the "official" electron/JS implementation. The C implementation does not get linked from there.

@ehmry ehmry merged commit 24bc2b8 into NixOS:master May 4, 2020
@Sohalt
Copy link
Contributor Author

Sohalt commented May 4, 2020

Thanks!

@Sohalt Sohalt deleted the orcac branch May 4, 2020 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehmry ehmry ehmry requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Sohalt @grahamc @ehmry