Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtk3: fix build on darwin #81485

Merged
merged 1 commit into from Mar 2, 2020
Merged

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Mar 2, 2020

Motivation for this change

gdkquartz-gtk-only.h is now included in distribution tarballs https://gitlab.gnome.org/GNOME/gtk/-/commit/235d28f02d54e6601cef51fec91d46961f64009e

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@7c6f434c
Copy link
Member

7c6f434c commented Mar 2, 2020

Hm, should this be staging, I wonder? @LnL7 maybe you have some advice?

@marsam
Copy link
Contributor Author

marsam commented Mar 2, 2020

I think it's safe to go to master, since it only affects darwin, and those packages are currently broken

@worldofpeace
Copy link
Contributor

Yeah, nixpkgs-unstable is blocked https://hydra.nixos.org/build/113759839

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build gtk3

this didn't build on darwin for some reason

@worldofpeace worldofpeace merged commit d7fa8da into NixOS:master Mar 2, 2020
@worldofpeace
Copy link
Contributor

Confirmed this wasn't a problem on stable https://hydra.nixos.org/job/nixpkgs/nixpkgs-20.03-darwin/gtk3.x86_64-darwin

@marsam marsam deleted the fix-gtk3-darwin branch May 31, 2023 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants