Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] Init bazel 1 #81491

Closed
wants to merge 1 commit into from
Closed

[20.03] Init bazel 1 #81491

wants to merge 1 commit into from

Conversation

mjlbach
Copy link
Contributor

@mjlbach mjlbach commented Mar 2, 2020

Motivation for this change

Cherry pick from #81033 for fixing tf1 build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mjlbach
Add bazel 1.2.1
d70c8db 
(cherry picked from commit 1c4f22a)
@mjlbach mjlbach requested a review from Profpatsch as a code owner March 2, 2020 08:14
@mjlbach mjlbach changed the title Add bazel 1 [20.03] Init bazel 1 Mar 2, 2020
@ofborg ofborg bot requested a review from mboes March 2, 2020 08:20
@mjlbach mjlbach mentioned this pull request Mar 2, 2020
Merged
10 tasks
@mjlbach mjlbach closed this Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Profpatsch Profpatsch Awaiting requested review from Profpatsch Profpatsch is a code owner

@mboes mboes Awaiting requested review from mboes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mjlbach