Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert scripts/nixops to setuptools entry point #1240

Merged
merged 1 commit into from Mar 12, 2020

Conversation

adisbladis
Copy link
Member

This is more idiomatic & makes it possible to run python -m nixops.

@teto
Copy link
Member

teto commented Mar 2, 2020

I love entrypoints as a convenience but this can be costly in startup time papis/papis#217

@grahamc
Copy link
Member

grahamc commented Mar 3, 2020

Mind rebasing (redoing) on current master?

@adisbladis adisbladis force-pushed the entrypoint branch 2 times, most recently from 273ff7a to 39b7700 Compare March 3, 2020 02:41
@adisbladis
Copy link
Member Author

@grahamc Rebased on master.

e.print_all_backtraces()
sys.exit(1)
#!/usr/bin/env bash
exec python -m nixops "$@"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just for backwards compatibility at dev time?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly.

@grahamc grahamc merged commit 389bbb0 into NixOS:master Mar 12, 2020
@grahamc grahamc added this to the 2.0 milestone Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants