Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.dash*: bump #81489

Merged
merged 4 commits into from Mar 2, 2020
Merged

pythonPackages.dash*: bump #81489

merged 4 commits into from Mar 2, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Mar 2, 2020 •
edited

Motivation for this change

noticed some failures with #81144, so i bumped the entire package set

closes #81144

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
[13 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/81489
5 package marked as broken and skipped:
python27Packages.dask-glm python27Packages.dask-image python27Packages.dask-jobqueue python27Packages.dask-mpi python27Packages.dask-xgboost

12 package built:
python27Packages.dash python27Packages.dash-core-components python27Packages.dash-renderer python27Packages.dash-table python37Packages.dash python37Packages.dash-core-components python37Packages.dash-renderer python37Packages.dash-table python38Packages.dash python38Packages.dash-core-components python38Packages.dash-renderer python38Packages.dash-table

@jonringer jonringer requested a review from FRidh as a code owner March 2, 2020 07:28
@ofborg ofborg bot requested a review from antoinerg March 2, 2020 07:39
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python27Packages.dash python27Packages.dash-core-components python27Packages.dash-renderer python27Packages.dash-table python37Packages.dash python37Packages.dash-core-components python37Packages.dash-renderer python37Packages.dash-table python38Packages.dash python38Packages.dash-core-components python38Packages.dash-renderer python38Packages.dash-table

@jonringer jonringer merged commit 52c5c8a into NixOS:master Mar 2, 2020
@antoinerg
Copy link
Contributor

Thank you @jonringer for taking this on!

Dash is the main package that users usually install via pip. In turns it installs all the other dependencies that it strictly depends on (https://github.com/plotly/dash/blob/v1.9.1/requires-install.txt). Therefore one has to bump the entire package set whenever a new version of Dash comes out.

@antoinerg antoinerg mentioned this pull request Mar 2, 2020
Closed
@jonringer jonringer deleted the bump-dash branch March 2, 2020 17:50
@jonringer
Copy link
Contributor Author

Thank you @jonringer for taking this on!

Dash is the main package that users usually install via pip. In turns it installs all the other dependencies that it strictly depends on (https://github.com/plotly/dash/blob/v1.9.1/requires-install.txt). Therefore one has to bump the entire package set whenever a new version of Dash comes out.

Yep, that's what I determined as well, :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@antoinerg antoinerg Awaiting requested review from antoinerg

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @antoinerg