services.mailman: Give mailman a posix group #81468
Conversation
| install -m 0700 -o mailman -g nogroup -d $mailmanDir | ||
| install -m 0700 -o ${cfg.webUser} -g nogroup -d $mailmanWebDir | ||
| install -m 0700 -o mailman -g mailman -d $mailmanDir | ||
| install -m 0700 -o ${cfg.webUser} -g mailman -d $mailmanWebDir |
There was a problem hiding this comment.
I don’t understand the purpose of this change. The directories are not group-readable.
There was a problem hiding this comment.
Oof sorry, I guess I forgot to include that part. Fixing.
There was a problem hiding this comment.
Also for what it's worth this isn't the only way to do this. Another workaround would be to set mod 0711 on the directories, and make some subparts of them world-readable, but using membership in a shared group seems slightly cleaner to me.
This greatly simplifies things like permitting nginx to read `/var/lib/mailman-web/static`, or non-root postfix to read `/var/lib/mailman/data`
benley
force-pushed
the
benley/mailman-group
branch
from
dd27387
to
8a6c32a
Compare
|
Hello, I'm a bot and I thank you in the name of the community for your contributions. Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human. If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do: If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list. If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past. If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments. Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel. |
stale
bot
added
the
2.status: stale
stale
bot
removed
the
2.status: stale
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
Mailmain has a group in nixpkgs now from what I can see. |
Motivation for this change
This greatly simplifies things like permitting nginx to read
/var/lib/mailman-web/static, or non-root postfix to read/var/lib/mailman/dataThings done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)