Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitaly: fix build #81506

Closed

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented Mar 2, 2020

Updated dep git2go ecaeb7a21d47 -> v0.28.5 to fix build problem.

go/src/github.com/libgit2/git2go/git_dynamic.go:10:3: error: #error "Invalid libgit2 version; this git2go supports libgit2 v0.27"
   10 | # error "Invalid libgit2 version; this git2go supports libgit2 v0.27"
      |   ^~~~~
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Updated dep git2go ecaeb7a21d47 -> v0.28.5 to fix build problem.
@ghost
Copy link

ghost commented Mar 3, 2020

Didn't see this soon enough, it fixes #81636
But I think this should be done in upstream or by setting the version in default.nix, because deps.nix is automatically generated.

@ghost ghost mentioned this pull request Mar 3, 2020
10 tasks
@ghost
Copy link

ghost commented Mar 3, 2020

Fix is included in #81556.

@ghost ghost closed this Mar 3, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant