@GrahamcOfBorg build python38Packages.poetry

actually, i need ofborg to evaluate python38.withPackages(ps: with ps; [poetry]), not sure how to do that

@jonringer I recently implemented the same fix for poetry2nix as a hook: https://github.com/nix-community/poetry2nix/blob/master/hooks/fixup-hook.sh.

It's better as a hook in regards to overrides.

I used to just build a sdist first, as I needed that anyway when distributing source code. IMO that's how we should do it when building from git.

this does solve the related issue:

[09:15:33] jon@jon-desktop /home/jon/projects/nixpkgs (avoid-test-dir)
$ nix-shell -p "with import ./. {}; python38.withPackages(ps: with ps; [poetry])"

[nix-shell:/home/jon/projects/nixpkgs]$

I used to just build a sdist first, as I needed that anyway when distributing source code. IMO that's how we should do it when building from git.

I don't think we have a good mechanism to determine this, as both will hand us a tar.gz. I think going the hook route is fine if you want me to refactor to something similar to what @adisbladis posted

I don't think we have a good mechanism to determine this, as both will hand us a tar.gz.

Right, it would be a Nix function building a derivation, e.g. buildSetuptoolsSdist.

I changed it to being a hook

Seeing as the "tests" package on pypi https://pypi.org/project/tests/ is defunct, I think it's safe that you will never want a top-level "tests" package

Right, it would be a Nix function building a derivation, e.g. buildSetuptoolsSdist.

or use the pre-existing format switch, and just have format = "sdist"; in an expression. The other options flit, pyproject, wheel, egg, other are all mutually exclusive with building from sdist

Now that we're talking about hooks, I started off a hook that would remove requirements from a wheel master...FRidh:python-deps-hook, that way it should work regardless of where the dependency is listed. It's not functioning (need to look further into zipfile class) but it shows the idea.

Now that we're talking about hooks, I started off a hook that would remove requirements from a wheel master...FRidh:python-deps-hook, that way it should work regardless of where the dependency is listed. It's not functioning (need to look further into zipfile class) but it shows the idea.

For packages that over-pin, I think this is great, but it still leans more on having tests to verify that a package set is still valid. (Overall, this is still needed. Testing is mostly orthogonal)

It would remove a lot of pain around use-cases where substituteInPlace/sed is used to do exactly this

with current changes, this has the expected behavior:

[11:00:19] jon@jon-desktop /home/jon/projects/nixpkgs (avoid-test-dir)
$ NIX_PATH=nixpkgs=$PWD nix-shell -p "python38.withPackages(ps: with ps; [poetry])"

[nix-shell:/home/jon/projects/nixpkgs]$ poetry --version
Poetry version 1.0.3

[nix-shell:/home/jon/projects/nixpkgs]$ cat pkgs/development/python-modules/poetry/default.nix | grep version
  version = "1.0.3";

@FRidh does this look good to you? I know that the python ecosystem is mostly your baby

I hope we could fix it at the source side instead of fixing up but I think we may have to do it this anyway.

Something I quickly gave a try. So far the issue have been the packages for which an sdist was built using poetry. Rebuilding an sdist for those requires poetry resulting in recursion. The main issue is with those packages built using poetry so I prefer to look at that deeper before using the hammer.
https://github.com/NixOS/nixpkgs/compare/master...FRidh:sdist?expand=1

Actually I do not want to spend time on this, let's merge.