Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-sam-cli: fix depency and update #82867

Merged
merged 4 commits into from Mar 18, 2020
Merged

aws-sam-cli: fix depency and update #82867

merged 4 commits into from Mar 18, 2020

Conversation

ciil
Copy link
Member

@ciil ciil commented Mar 18, 2020

Motivation for this change

Fixes and updates aws-sam-cli, which had failed since 511ebca because of the strict tomlkit dependecy: https://hydra.nixos.org/build/113853232. From what I could gather from nixpkgs-review wip, this update, especially the jmespath bump, didn't affect other packages. All the failures I saw were because of other reasons.

Tested the cli with a new lambda, saw no problems.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ciil ciil changed the title Fix aws sam aws-sam-cli: fix depency and update Mar 18, 2020
@ofborg ofborg bot requested review from dhl and lo1tuma March 18, 2020 19:01
@jonringer
Copy link
Contributor 

[195 built (44 failed), 126 copied (352.4 MiB), 67.3 MiB DL]
error: build of '/nix/store/kxiwrv4rrwwkfdhnwqc24rxpkwjy7c7f-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/82867
11 package marked as broken and skipped:
python27Packages.paperspace python37Packages.blaze python37Packages.odo python37Packages.paperspace python38Packages.arviz python38Packages.blaze python38Packages.nipype python38Packages.odo python38Packages.optuna python38Packages.paperspace python38Packages.rl-coach

56 package failed to build:
apache-airflow ape dvc-with-remotes fluidasserts python27Packages.flowlogs_reader python27Packages.scrapy python37Packages.Quandl python37Packages.arviz python37Packages.cirq python37Packages.cufflinks python37Packages.dask-jobqueue python37Packages.datashader python37Packages.dftfit python37Packages.google_cloud_bigquery python37Packages.ibis-framework python37Packages.imbalanced-learn python37Packages.intake python37Packages.lammps-cython python37Packages.pymatgen python37Packages.pymatgen-lammps python37Packages.pymc3 python37Packages.rl-coach python37Packages.scrapy python37Packages.snowflake-connector-python python37Packages.snowflake-sqlalchemy python37Packages.streamz python37Packages.stumpy python37Packages.sumo python37Packages.sunpy python37Packages.trackpy python38Packages.Quandl python38Packages.apache-airflow python38Packages.celery python38Packages.cirq python38Packages.cufflinks python38Packages.dask-jobqueue python38Packages.datashader python38Packages.dftfit python38Packages.django-raster python38Packages.djmail python38Packages.flower python38Packages.google_cloud_bigquery python38Packages.ibis-framework python38Packages.imbalanced-learn python38Packages.intake python38Packages.lammps-cython python38Packages.pymatgen python38Packages.pymatgen-lammps python38Packages.pymc3 python38Packages.pywick python38Packages.scrapy python38Packages.snowflake-connector-python python38Packages.snowflake-sqlalchemy python38Packages.streamz python38Packages.sumo python38Packages.trackpy

301 package built:
ansible ansible-lint ansible_2_6 ansible_2_7 ansible_2_9 aws-adfs aws-google-auth aws-sam-cli aws_shell awscli awsebcli awslogs azure-cli bash-my-aws buildbot buildbot-full buildbot-ui cloud-custodian credstash csvs-to-sqlite elasticsearch-curator home-assistant iceshelf kargo lexicon luigi mapproxy mlflow-server nixops nixopsUnstable nixops_1_6_1 poretools python27Packages.PyLTI python27Packages.Quandl python27Packages.ansible python27Packages.apptools python27Packages.awkward python27Packages.aws-lambda-builders python27Packages.aws-sam-translator python27Packages.aws-xray-sdk python27Packages.bkcharts python27Packages.boto3 python27Packages.botocore python27Packages.cartopy python27Packages.celery python27Packages.cfn-lint python27Packages.chalice python27Packages.cnvkit python27Packages.colorcet python27Packages.credstash python27Packages.cufflinks python27Packages.drms python27Packages.envisage python27Packages.fiona python27Packages.flammkuchen python27Packages.flower python27Packages.fs-s3fs python27Packages.geopandas python27Packages.holoviews python27Packages.hvplot python27Packages.imbalanced-learn python27Packages.jmespath python27Packages.labelbox python27Packages.mapbox python27Packages.mapsplotlib python27Packages.mayavi python27Packages.moto python27Packages.nbsmoke python27Packages.pandas python27Packages.pyarrow python27Packages.pytest-ansible python27Packages.pytrends python27Packages.rasterio python27Packages.runway-python python27Packages.s3transfer python27Packages.sapi-python-client python27Packages.seaborn python27Packages.serverlessrepo python27Packages.smart_open python27Packages.statsmodels python27Packages.tiros python27Packages.trackpy python27Packages.transformers python27Packages.uproot python27Packages.uproot-methods python27Packages.vega python27Packages.vega_datasets python27Packages.vidstab python27Packages.warrant python37Packages.acoustics python37Packages.altair python37Packages.ansible-kernel python37Packages.ansible-runner python37Packages.aplpy python37Packages.atomman python37Packages.awkward python37Packages.aws-lambda-builders python37Packages.aws-sam-translator python37Packages.aws-xray-sdk python37Packages.batchgenerators python37Packages.bkcharts python37Packages.boto3 python37Packages.botocore python37Packages.caffe python37Packages.cartopy python37Packages.celery python37Packages.cfn-lint python37Packages.chalice python37Packages.cnvkit python37Packages.colorcet python37Packages.dask python37Packages.dask-glm python37Packages.dask-image python37Packages.dask-ml python37Packages.dask-mpi python37Packages.dask-xgboost python37Packages.distributed python37Packages.django-anymail python37Packages.django-raster python37Packages.djmail python37Packages.drms python37Packages.fastparquet python37Packages.fiona python37Packages.flammkuchen python37Packages.flower python37Packages.flowlogs_reader python37Packages.fs-s3fs python37Packages.gensim python37Packages.geopandas python37Packages.glymur python37Packages.google_cloud_monitoring python37Packages.hass-nabucasa python37Packages.hickle python37Packages.holoviews python37Packages.hvplot python37Packages.image-match python37Packages.imagecorruptions python37Packages.imgaug python37Packages.jmespath python37Packages.knack python37Packages.labelbox python37Packages.mapbox python37Packages.mesa python37Packages.mlflow python37Packages.moto python37Packages.nbsmoke python37Packages.nilearn python37Packages.nipype python37Packages.optuna python37Packages.osmnx python37Packages.osmpythontools python37Packages.pandas python37Packages.partd python37Packages.phik python37Packages.pims python37Packages.pvlib python37Packages.pyarrow python37Packages.pybids python37Packages.pyfftw python37Packages.pynamodb python37Packages.pytest-ansible python37Packages.pytrends python37Packages.pywick python37Packages.rasterio python37Packages.rpy2 python37Packages.runway-python python37Packages.s3fs python37Packages.s3transfer python37Packages.sapi-python-client python37Packages.scikit-bio python37Packages.scikitimage python37Packages.seaborn python37Packages.sentry-sdk python37Packages.serverlessrepo python37Packages.smart_open python37Packages.statsmodels python37Packages.stytra python37Packages.tablib python37Packages.tiros python37Packages.transformers python37Packages.uproot python37Packages.uproot-methods python37Packages.vega python37Packages.vega_datasets python37Packages.vidstab python37Packages.warrant python37Packages.wrf-python python37Packages.xarray python37Packages.xgboost python38Packages.acoustics python38Packages.altair python38Packages.ansible python38Packages.ansible-kernel python38Packages.ansible-lint python38Packages.ansible-runner python38Packages.aplpy python38Packages.atomman python38Packages.awkward python38Packages.aws-adfs python38Packages.aws-lambda-builders python38Packages.aws-sam-translator python38Packages.aws-xray-sdk python38Packages.batchgenerators python38Packages.bkcharts python38Packages.boto3 python38Packages.botocore python38Packages.buildbot python38Packages.buildbot-full python38Packages.buildbot-ui python38Packages.caffe python38Packages.cartopy python38Packages.cfn-lint python38Packages.chalice python38Packages.cnvkit python38Packages.colorcet python38Packages.credstash python38Packages.csvs-to-sqlite python38Packages.dask python38Packages.dask-glm python38Packages.dask-image python38Packages.dask-ml python38Packages.dask-mpi python38Packages.dask-xgboost python38Packages.distributed python38Packages.django-anymail python38Packages.drms python38Packages.fastparquet python38Packages.fiona python38Packages.flammkuchen python38Packages.flowlogs_reader python38Packages.fs-s3fs python38Packages.gensim python38Packages.geopandas python38Packages.glymur python38Packages.google_cloud_monitoring python38Packages.hickle python38Packages.holoviews python38Packages.hvplot python38Packages.image-match python38Packages.imagecorruptions python38Packages.imgaug python38Packages.jmespath python38Packages.knack python38Packages.labelbox python38Packages.mapbox python38Packages.mlflow python38Packages.moto python38Packages.nbsmoke python38Packages.nilearn python38Packages.osmnx python38Packages.osmpythontools python38Packages.pandas python38Packages.partd python38Packages.phik python38Packages.pims python38Packages.pvlib python38Packages.pyarrow python38Packages.pybids python38Packages.pyfftw python38Packages.pynamodb python38Packages.pytest-ansible python38Packages.pytrends python38Packages.rasterio python38Packages.rpy2 python38Packages.runway-python python38Packages.s3fs python38Packages.s3transfer python38Packages.sapi-python-client python38Packages.scikit-bio python38Packages.scikitimage python38Packages.seaborn python38Packages.serverlessrepo python38Packages.smart_open python38Packages.statsmodels python38Packages.stytra python38Packages.tablib python38Packages.tiros python38Packages.transformers python38Packages.uproot python38Packages.uproot-methods python38Packages.vega python38Packages.vega_datasets python38Packages.vidstab python38Packages.warrant python38Packages.wrf-python python38Packages.xarray python38Packages.xgboost s3bro s4cmd sourcehut.buildsrht sourcehut.dispatchsrht sourcehut.gitsrht sourcehut.hgsrht sourcehut.listssrht sourcehut.mansrht sourcehut.metasrht sourcehut.pastesrht sourcehut.todosrht streamlit tebreak visidata

jonringer
jonringer approved these changes Mar 18, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commits LGTM

there's a lot of noise, but I don't think there's any regressions from this package

@jonringer jonringer merged commit 5e33158 into NixOS:master Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@dhl dhl Awaiting requested review from dhl

@lo1tuma lo1tuma Awaiting requested review from lo1tuma

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ciil @jonringer