Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust: remove legacy cargo fetcher #82901

Merged
merged 1 commit into from Mar 19, 2020
Merged

rust: remove legacy cargo fetcher #82901

merged 1 commit into from Mar 19, 2020

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Mar 19, 2020

We have now migrated every single Rust package in NixPkgs! This deletes the
legacy fetcher, which is now unused.

Resolves #79975

CC @marsam @Ma27 @jonringer @zimbatm

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bhipple
rust: remove legacy cargo fetcher
a90ff19 
We have now migrated every single Rust package in NixPkgs! This deletes the
legacy fetcher, which is now unused.

Resolves NixOS#79975
@bhipple bhipple mentioned this pull request Mar 19, 2020
Closed
@bhipple
Copy link
Contributor Author

bhipple commented Mar 19, 2020 •
edited

Note no package rebuilds:

$ nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
...
Nothing changed

jonringer
jonringer approved these changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Nothing changed
https://github.com/NixOS/nixpkgs/pull/82901
$ nix-shell /home/jon/.cache/nixpkgs-review/pr-82901/shell.nix

@jonringer jonringer merged commit 05343f6 into NixOS:master Mar 19, 2020
@zimbatm
Copy link
Member

zimbatm commented Mar 19, 2020

nice work @bhipple !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@andir andir Awaiting requested review from andir

@LnL7 LnL7 Awaiting requested review from LnL7

@Mic92 Mic92 Awaiting requested review from Mic92 Mic92 is a code owner

Assignees
No one assigned
Labels
6.topic: rust 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rust Application Migration to fetchCargoTarball Implementation
3 participants
@bhipple @zimbatm @jonringer