New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fullscreen mode in MacOSX is almost unusable #8038
Comments
I've repro-ed on 10.14.6 I had a look at what other macOS apps do. Menubar
We would want to force a redraw below the global menubar. For the dock, it's simple. The full-screen apps I tried tended to simply suppress the dock. This conflicts with Apple advice, but eh, that's the go. https://developer.apple.com/design/human-interface-guidelines/macos/app-architecture/fullscreen-mode/ Note that macOS dock has an 'always visible' or 'hide/show on hover' option. In either case full-screen apps tend to suppress the dock entirely. |
I think the best solution would be:
|
I respectfully disagree, I think that when in fullscreen mode the underlying OS should never be able to interrupt the "immersed" experience. I would recommend that the MacOS menu bar were not allowed to pop up at all while playing: it causes a very stressful and frustrating gaming experience. |
Does SDL have something like autolayout? I'd love to take a swing at this as my first issue!
I understand what you're communicating, but Apple users wants stuff to feel native. Of course there are outliers out there, but I think pushing the game toolbar would be what feels the most apple like, and would maybe not even be intrusive? |
I'm sorry but I have to insist on my point of view because I believe that the proposed solution is not really solving the problem. In my opinion it would be a major mistake to have the toolbar to move around just because you reach the edge of the screen with the mouse. Unless I misunderstood something about the proposed solution, the resulting behavior would not be significantly different from the one I linked in the video, with the only change that instead of the toolbar being hidden by the MacOS UI it would be moved downwards. So instead of being frustrated by reason A a player would get frustrated by reason B. And the toolbar is what one uses 3/4 of the time spent playing. I tried to install https://play0ad.com/ and their full screen mode doesn't allow MacOS to interfere. Not to mention that this setting: Pan window when mouse is at the edge in OpenTTD would remain broken for MacOS users. I hope I'm giving you enough evidence that there is a reason why everybody is doing like this; OpenTTD is a game and not a standard application where edges are not so important. |
Apple guidelines for full-screen don't mandate the OS menu bar behaviour, but they mandate dock behaviour (allow show unless it's immersive, e.g. game), and we can infer from that. https://developer.apple.com/design/human-interface-guidelines/macos/app-architecture/fullscreen-mode/ TL;DR I see no problem with hiding the OS menu bar in full-screen. I play other Mac games that hide the menu bar permanently or only show it in certain circumstances. Aside |
In my opinion if one is concerned about battery status, he can play in windowed mode or quickly switch from full screen to windowed mode using Cmd + Enter. I see this annoyance as far inferior and more bearable than having to hunt down the toolbar every time you forget to not move the cursor too close to the edge. |
I'm not sure if you've already solved the issue but here's what I've done:
If you still have problems, here's a video that helped me out with OpenTTD and some other games like Pillars of Eternity. Hope that helps! |
Hi guys, first of all thank you for the work you're doing, the game is every day more awesome :) Tonight I tested OpenTTD 1.11.0-beta1 to see if the issue is solved, however I think it still needs some refinement.
I recorded a video displaying the issues. openttd-fullscreen.mp4 |
See also my report of same (item 2 in linked issue) #8486 (comment) |
Issues resolved by recent Mac video changes. |
In version 1.11.0-beta2 the behavior is improved but not perfect yet:
Here a demo video: fullscreen.mp4 |
This should be fixed in tomorrow's nightly (20210302 or later). |
@orudge I tested the nightly and I confirm that this is fixed now, thanks! :) |
Version of OpenTTD
1.9.3
Expected result
If the game is set to fullscreen, the underlying OS should not get into the way while playing
Actual result
If I get too close to the upper or the lower border of the game view while being full screen, the menubar and the dock of MacOSX often get into the way making it very difficult and painful to play. Here is a short video showing why it is so annoying.
I'm using MacOS 10.15.3
Note: OpenRCT2 has a fullscreen mode that doesn't suffer from this problem (if it can be useful).
Steps to reproduce
The text was updated successfully, but these errors were encountered: