Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elmPackages: minor cleanups #82870

Merged
merged 1 commit into from Mar 18, 2020

Conversation

turboMaCk
Copy link
Member

  • Make sure generate script uses node2nix version from the nixpkgs
  • regenerate code generated by node2nix
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@domenkozar I was trying to find a better way around the issue we hit with elm-coverage but I had no luck. It seems to me that overriding dependecy of package with node2nix is either very hard or even impossible. I certainly don't know how to solve this in better way.

* Make sure generate script uses node2nix version from the nixpkgs
* regenerate code generated by node2nix
@turboMaCk
Copy link
Member Author

@GrahamcOfBorg build elmPackages


set -eu -o pipefail

rm -f node-env.nix
node2nix --nodejs-10 \
$(nix-build $ROOT -A nodePackages.node2nix --no-out-link)/bin/node2nix \
--nodejs-10 \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are the important changes

elm-test = patchBinwrap [elmi-to-json] nodePkgs.elm-test;
elm-verify-examples = patchBinwrap [elmi-to-json] nodePkgs.elm-verify-examples;
elm-coverage =
let patched = patchBinwrap [elm elmi-to-json] nodePkgs.elm-coverage;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was not needed. npm installer doesn't use binwrap but it's own mechanism to download binary - this is already solved in preBuild hook.

@domenkozar domenkozar merged commit 2f9d761 into NixOS:master Mar 18, 2020
@turboMaCk turboMaCk deleted the elm-packages-refactoring branch February 2, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants