Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.celery: 4.4.0 -> 4.4.2 #82871

Merged
merged 3 commits into from Mar 19, 2020
Merged

pythonPackages.celery: 4.4.0 -> 4.4.2 #82871

merged 3 commits into from Mar 19, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Mar 18, 2020 •
edited

Motivation for this change

noticed it was broken when reviewing another package

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
[21 built (1 failed), 5 copied (1.4 MiB), 0.3 MiB DL]
error: build of '/nix/store/46fqim9hajz3fj55fd3ifaizylpp5g30-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/82871
4 package failed to build:
python38Packages.celery python38Packages.django-raster python38Packages.djmail python38Packages.flower

22 package built:
python27Packages.billiard python27Packages.celery python27Packages.flower python27Packages.kombu python37Packages.billiard python37Packages.celery python37Packages.django-raster python37Packages.djmail python37Packages.flower python37Packages.kombu python37Packages.sentry-sdk python38Packages.billiard python38Packages.kombu sourcehut.buildsrht sourcehut.dispatchsrht sourcehut.gitsrht sourcehut.hgsrht sourcehut.listssrht sourcehut.mansrht sourcehut.metasrht sourcehut.pastesrht sourcehut.todosrht

@jonringer jonringer requested a review from FRidh as a code owner March 18, 2020 19:48
@jonringer jonringer changed the title Fix celery pythonPackages.celery: 4.4.0 -> 4.4.2 Mar 18, 2020
@jonringer
Copy link
Contributor Author

failure due to python3.8 is not supported by celery yet:

builder for '/nix/store/1y7hinnnzddi9qqjh42wrzyr62lqzr99-python3.8-celery-4.4.2.drv' failed with exit code 1; last 10 log lines:

    Traceback (most recent call last):
      File "/nix/store/yhvjg3gkpf7r84kpacav5jdz90izjys2-python3.8-celery-4.4.2/lib/python3.8/site-packages/celery/app/trace.py", line 362, in trace_task
        raise InvalidTaskError(
    celery.exceptions.InvalidTaskError: Task keyword arguments is not a mapping

      warn(RuntimeWarning(

  -- Docs: https://docs.pytest.org/en/latest/warnings.html
  = 1 failed, 2415 passed, 150 skipped, 5 deselected, 37 warnings in 136.17s (0:02:16) =
cannot build derivation '/nix/store/zsapjm3xcprqg8rjrwy0rls9kb3ay93i-python3.8-django-raster-0.7.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/aspp0p2a4xnc4l47hv1hsii7li3xppyc-python3.8-djmail-1.1.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/67ndvbzhkiwkpgp32hpzg21fhn2swpl5-python3.8-flower-0.9.3.drv': 1 dependencies couldn't be built

@jonringer
Copy link
Contributor Author

going to merge this in 24hrs, unless someone has an objection. Fixes broken builds

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python2Packages.celery
@GrahamcOfBorg build python3Packages.celery
@GrahamcOfBorg build python38Packages.celery

@jonringer jonringer merged commit 1c4bb80 into NixOS:master Mar 19, 2020
@jonringer jonringer deleted the fix-celery branch March 19, 2020 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonringer