Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tasty-tap: fix failing build #82906

Merged
merged 1 commit into from Mar 19, 2020
Merged

tasty-tap: fix failing build #82906

merged 1 commit into from Mar 19, 2020

Conversation

sevanspowell
Copy link
Contributor

Motivation for this change

tasty-tap was failing to build because the changes in the patch it was trying to apply had already been released. Removed the patch and marked the package unbroken.

See #71017 for the history.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sevanspowell
tasty-tap: fix failing build
126c491 
- tasty-tap's tests were failing. In
  NixOS#71017 a patch generated from a
  PR was applied to fix this.
- That PR has now been merged into tasty-tap and was released with
  version 0.1.0.
- tasty-tap is now at version 0.1.0 in nixpkgs and so the patch fails
  to apply, breaking the build.
- Removed the patch and removed tasty-tap from list of broken
  packages.
@cdepillabout
Copy link
Member

✌️

Compiles locally, so looks good

@cdepillabout cdepillabout merged commit e915d37 into NixOS:haskell-updates Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sevanspowell @cdepillabout