Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix libhybris regression following gcc target-specific libraries split #100

Merged
merged 1 commit into from Mar 19, 2020

Conversation

samueldr
Copy link
Member

This Nixpkgs commit introduced the breaking change:

libsupc++.a is not where it was previously.

@samueldr samueldr added the 4. type: regression Something stopped working label Mar 19, 2020
@@ -35,6 +37,11 @@ stdenv.mkDerivation {
--replace "/usr/bin/file" "${file}/bin/file"
'';

NIX_LDFLAGS = [
# For libsupc++.a
"-L${stdenv.cc.cc.out}/${libPrefix}/lib/"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this'll double-up to //, but that's basically a no-op in directory traversal.

@samueldr samueldr merged commit 2673958 into NixOS:master Mar 19, 2020
@samueldr samueldr deleted the fix/libhybris-regression-gcc branch March 19, 2020 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. type: regression Something stopped working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant