Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ivan: add full iconset #82903

Merged
merged 1 commit into from Apr 15, 2020
Merged

ivan: add full iconset #82903

merged 1 commit into from Apr 15, 2020

Conversation

ghost
Copy link

@ghost ghost commented Mar 19, 2020 •
edited by ghost

Motivation for this change

A complete set of icons for the ivan package has been added 馃懡

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg build ivan

nh2
nh2 approved these changes Apr 15, 2020
View reviewed changes
Copy link
Contributor

@nh2 nh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runs fine for me and the diff looks correct.

@nh2 nh2 merged commit b5765e6 into NixOS:master Apr 15, 2020
@ghost
Copy link
Author

ghost commented Jul 20, 2020

@nh2 Thanks! 馃懡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@nh2