Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libslirp: init at 4.2.0 #82905

Merged
merged 1 commit into from Mar 19, 2020
Merged

libslirp: init at 4.2.0 #82905

merged 1 commit into from Mar 19, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Mar 19, 2020

Motivation for this change

https://github.com/rootless-containers/slirp4netns/releases/tag/v1.0.0-beta.0

libslirp is no longer included in slirp4netns and needs be installed separately.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS (build failure)
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @orivej @saschagrunert

orivej
orivej reviewed Mar 19, 2020
View reviewed changes
pkgs/tools/networking/libslirp/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@orivej-nixos orivej-nixos merged commit e57d07f into NixOS:master Mar 19, 2020
@zowoq zowoq deleted the slirp branch March 19, 2020 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orivej orivej orivej left review comments

@saschagrunert saschagrunert saschagrunert approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zowoq @orivej @saschagrunert @orivej-nixos