Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brave: 1.4.96 -> 1.5.112 #82895

Merged
merged 1 commit into from Mar 19, 2020
Merged

brave: 1.4.96 -> 1.5.112 #82895

merged 1 commit into from Mar 19, 2020

Conversation

JeffLabonte
Copy link
Contributor

@JeffLabonte JeffLabonte commented Mar 19, 2020 •
edited

Keep brave updated to the latest release

(cherry picked from commit 418e3e4)
Reasons: Keep the browser up-to-date as much as possible.

Motivation for this change

Keep the browser up-to-date

Things done

Backport PR #82894

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@JeffLabonte
brave: 1.4.96 -> 1.5.112
4fa0d2d 
Keep brave updated to the latest release

(cherry picked from commit 418e3e4)
Reasons: Keep the browser up-to-date as much as possible.
@JeffLabonte
Copy link
Contributor Author

Builds with nixpkgs-review

@ofborg ofborg bot requested review from rht and uskudnik March 19, 2020 00:48
jonringer
jonringer approved these changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

[2 built, 77 copied (158.1 MiB), 37.7 MiB DL]
https://github.com/NixOS/nixpkgs/pull/82895
1 package built:
brave

@jonringer jonringer merged commit 294fd3c into NixOS:release-20.03 Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@rht rht Awaiting requested review from rht

@uskudnik uskudnik Awaiting requested review from uskudnik

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JeffLabonte @jonringer