Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chromium: 80.0.3987.132 -> 80.0.3987.149 #82874

Merged
merged 1 commit into from Mar 19, 2020
Merged

chromium: 80.0.3987.132 -> 80.0.3987.149 #82874

merged 1 commit into from Mar 19, 2020

Conversation

primeos
Copy link
Member

@primeos primeos commented Mar 18, 2020 •
edited

Status

platform attribute status tester
x86_64 chromium ✔️ @Frostman and @danielfullmer
x86_64 nixosTests.chromium ✔️ @Frostman and @danielfullmer
x86_64 google-chrome ✔️ @primeos
aarch64 chromium @thefloweringash

Info

https://chromereleases.googleblog.com/2020/03/stable-channel-update-for-desktop_18.html

This update includes 13 security fixes.

CVEs:
CVE-2020-6422 CVE-2020-6424 CVE-2020-6425 CVE-2020-6426 CVE-2020-6427
CVE-2020-6428 CVE-2020-6429 CVE-2019-20503 CVE-2020-6449

Note: The release of version 81 is currently on pause:
https://chromereleases.googleblog.com/2020/03/upcoming-chrome-and-chrome-os-releases.html

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danielfullmer
Copy link
Contributor

I was able to successfully build and test chromium and nixosTests.chromium on x86_64.

@primeos If you're interested, in the future you can add me as an another potential tester for these two attributes. I have a fancy new 32-core 3970x threadripper that loves big parallel compile jobs like these.

@Frostman
Copy link
Member

nixosTests.chromium passed (x86_64)

@primeos
Copy link
Member Author

primeos commented Mar 19, 2020

@primeos If you're interested, in the future you can add me as an another potential tester for these two attributes. I have a fancy new 32-core 3970x threadripper that loves big parallel compile jobs like these.

Awesome, thank you very much for the offer! I've added you in #78450 :)

Can you also run/test Chromium on this system or is it headless? If you can run Chromium it might e.g. make sense if you'd test the PR for nixos-unstable and @Frostman for the stable channel (running nixosTests.chromium was fine so far, but it might be nice to quickly check WebGL (e.g. https://get.webgl.org/) and video+audio (e.g. YT) manually as well).

@primeos primeos merged commit 7545ccb into NixOS:master Mar 19, 2020
primeos added a commit that referenced this pull request Mar 19, 2020
@primeos
chromium: 80.0.3987.132 -> 80.0.3987.149
b3ee6e4 
https://chromereleases.googleblog.com/2020/03/stable-channel-update-for-desktop_18.html

This update includes 13 security fixes.

CVEs:
CVE-2020-6422 CVE-2020-6424 CVE-2020-6425 CVE-2020-6426 CVE-2020-6427
CVE-2020-6428 CVE-2020-6429 CVE-2019-20503 CVE-2020-6449

Note: The release of version 81 is currently on pause:
https://chromereleases.googleblog.com/2020/03/upcoming-chrome-and-chrome-os-releases.html
(cherry picked from commit fe60ff7)
Backport of #82874.
@primeos primeos mentioned this pull request Mar 19, 2020
Merged
10 tasks
@danielfullmer
Copy link
Contributor

@primeos Sure, I can run/test chromium on this system as well.

@thefloweringash
Copy link
Member

LGTM on Aarch64 with a quick test of chromium including youtube. (Better late than never!)

chromiumDev failed to build due to the following, which looks related to 02ca096:

ln: failed to create symbolic link 'buildtools/linux64/clang-format': File exists

@primeos
Copy link
Member Author

primeos commented Mar 24, 2020

@primeos Sure, I can run/test chromium on this system as well.

Awesome, in that case I would like to cc you (@danielfullmer) for the nixos-unstable builds and @Frostman for the nixos-stable builds to split the work and optimize the testing if that's ok for both of you :)

chromiumDev failed to build [...]

@thefloweringash thanks for notifying me :) I've reverted 02ca096 and after #83290 is merged (which'll probably take a few weeks to hit the channel, but I feel a bit more comfortable pushing this to staging first) it should be fine again (my build is still running but at least it get's past the configuration phase now).

@TredwellGit TredwellGit added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security 2.status: work-in-progress 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@primeos @danielfullmer @Frostman @thefloweringash @TredwellGit