Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.trackpy: 0.4.1 -> 0.4.2, mark broken #82878

Merged
merged 1 commit into from Mar 19, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Mar 18, 2020

Motivation for this change

noticed it was broken when reviewing another package, tried to bump it, but it still failed:

        try:
            with warnings.catch_warnings(record=True):
                # We want to silence any warnings about, e.g. moved modules.
                warnings.simplefilter("ignore", Warning)
>               return pickle.load(f)
E               TypeError: _reconstruct: First argument must be a sub-type of ndarray

looks like serialization is broken with current pandas.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor Author

cleans up some noise when reviewing packages

@jonringer jonringer merged commit 9fbeaa4 into NixOS:master Mar 19, 2020
@jonringer jonringer deleted the disable-trackpy branch March 19, 2020 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant