Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.snowflake-connector-python: 2.2.0 -> 2.2.2 #82877

Merged
merged 1 commit into from Mar 18, 2020
Merged

python3Packages.snowflake-connector-python: 2.2.0 -> 2.2.2 #82877

merged 1 commit into from Mar 18, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Mar 18, 2020 •
edited

Motivation for this change

noticed it was broken while reviewing another PR

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer requested a review from FRidh as a code owner March 18, 2020 20:28
@jonringer
Copy link
Contributor Author

fixes broken build

@jonringer jonringer merged commit 29c2264 into NixOS:master Mar 18, 2020
@jonringer jonringer deleted the fix-snowflake branch March 18, 2020 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonringer