Let base style respond to font animations #22331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 19, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2109694
branch
3 times, most recently
from
88e52c4
to
a6e7a59
Compare
Whenever we are animating a property that affects the font, we must avoid the base computed style optimization. This is because the base style may contain em, ex (etc) units which needs to resolve against the font. Hence, set a flag when a font-affecting animation is applied. Bug: 437689 Change-Id: I8bd950a1df9c8e100c4ca2b7318b0389a2acfad0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109694 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#752498}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2109694
branch
from
a6e7a59
to
78b35a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever we are animating a property that affects the font, we must
avoid the base computed style optimization. This is because the base
style may contain em, ex (etc) units which needs to resolve against
the font.
Hence, set a flag when a font-affecting animation is applied.
Bug: 437689
Change-Id: I8bd950a1df9c8e100c4ca2b7318b0389a2acfad0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109694
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#752498}