Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.cufflinks: 0.16 -> 0.17.3 #82880

Merged
merged 1 commit into from Mar 18, 2020
Merged

python3Packages.cufflinks: 0.16 -> 0.17.3 #82880

merged 1 commit into from Mar 18, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Mar 18, 2020 •
edited

Motivation for this change

noticed it was broken when reviewing another package

the "production code" has already been updated for pandas>=1.0, but some of the tests still use removed attributes

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
[3 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/82880
3 package built:
python27Packages.cufflinks python37Packages.cufflinks python38Packages.cufflinks

@jonringer jonringer requested a review from FRidh as a code owner March 18, 2020 20:39
@ofborg ofborg bot requested a review from globin March 18, 2020 20:46
@jonringer jonringer merged commit 75b0fc6 into NixOS:master Mar 18, 2020
@jonringer jonringer deleted the bump-cufflinks branch July 8, 2020 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonringer