Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust: 1.41 -> 1.42 #82881

Closed
wants to merge 1 commit into from
Closed

rust: 1.41 -> 1.42 #82881

wants to merge 1 commit into from

Conversation

kevincox
Copy link
Contributor

@kevincox kevincox commented Mar 18, 2020 •
edited

Note: The removed patch has been merged in rust-lang/rust#69381

Motivation for this change

https://blog.rust-lang.org/2020/03/12/Rust-1.42.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kevincox
rust: 1.41 -> 1.42
68b7520 
Note: The removed patch has been merged in rust-lang/rust#69381
@kevincox kevincox self-assigned this Mar 18, 2020
@Ericson2314
Copy link
Member

Already done in #82447

@alyssais alyssais deleted the rust-1.42 branch March 30, 2020 10:40
@alyssais
Copy link
Member

Note: The removed patch has been merged in rust-lang/rust#69381

@kevincox fwiw, this PR would have caused a regression, because while the patch was merged into Rust master, it was not in this release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 Awaiting requested review from LnL7

@Mic92 Mic92 Awaiting requested review from Mic92 Mic92 is a code owner

Assignees

@kevincox kevincox

Labels
6.topic: rust 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kevincox @Ericson2314 @alyssais