python3Packages.spyder: add v3.x #82910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously top-level/python-packages.nix called spyder-kernels v0.5 for Py2k. Now both v0.5 and v1.8 (default.nix) are in pythonPackages, as required by cq-editor and spyder v4 respectively. v0.5 also now comes from GitHub instead of PyPi, with checks enabled.
cq-editor currently requires spyder v3.x
|
Hmm, @FRidh I guess we were ok adding multiple versions of this package here? |
|
It's not the preferred solution, but sometimes there's not a good solution. It will just be suprising for people if packages from the different versions get inter-mixed in the same environment |
|
Hopefully we won't cause issues in nixpkgs with catch_conflicts. |
|
I highly doubt any other package than spyder will depend on spyder-kernel. But you're right, it's not the preferred way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
cq-editor requires the library Spyder v3, which in turn requires Spyder-kernels v0.x. I've added them as
python3Packages.spyder_3andpython3Packages.spyder-kernels_0_5respectively.I haven't touched the spyder application (v4),
pythonPackages.spyderorpythonPackages.spyder-kernels.Also, I enabled tests on
python3Packages.spyder-kernels_0_5and got them to pass (with the exception of the tests for their optional UMR feature, which make assumptions about the filesystem that fail in nix).Regarding the still broken Spyder v4, it requires Jedi 14.0 but we have 15.2. If this commit sticks spyder-ide/spyder@694f1ce, the next release of Spyder should have Jedi pinned to 15.2. So if the stars align and no one bumps our Jedi version we might get it working then.
Related to #80083
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)cq-editor builds fine.
pythonPackages.spyderbuilds for python 3.6 and 3.7, butpython35Packages.sqlalchemy,python38Packages.ropeare currently broken preventing builds on those versions of Python.I think this will need to be backported to release-20.03 as well.