Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.google*: fix many packages #82884

Merged
merged 17 commits into from Mar 19, 2020
Merged

python3Packages.google*: fix many packages #82884

merged 17 commits into from Mar 19, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Mar 18, 2020 •
edited

Motivation for this change

noticed they were broken

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer requested a review from FRidh as a code owner March 18, 2020 21:39
@ofborg ofborg bot requested a review from costrouc March 18, 2020 21:54
@jonringer
Copy link
Contributor Author

looks like that's it for google packages, some of their dependencies are still failing

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg eval

@ofborg ofborg bot requested review from terlar and lsix March 18, 2020 23:44
@jonringer
Copy link
Contributor Author 

24 built (11 failed), 14 copied (4.4 MiB), 0.5 MiB DL]
error: build of '/nix/store/857q80a2mx2m9niqwi1gv2zzzpj7zd47-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/82884
2 package marked as broken and skipped:
python37Packages.pyro-ppl python38Packages.pyro-ppl

18 package failed to build:
fluidasserts python27Packages.tensorflow-bin python37Packages.cirq python37Packages.google_cloud_bigquery python37Packages.ignite python37Packages.pytorchWithCuda python37Packages.pywick python37Packages.rl-coach python37Packages.tensorly python37Packages.torchvision python38Packages.cirq python38Packages.google_cloud_bigquery python38Packages.ignite python38Packages.pytorch python38Packages.pytorchWithCuda python38Packages.pywick python38Packages.tensorly python38Packages.torchvision

106 package built:
beancount deja-dup duplicity duply dvc-with-remotes fava gcalcli gmailieer kmymoney patroni python27Packages.google-auth-httplib2 python27Packages.google-auth-oauthlib python27Packages.google_auth python27Packages.google_cloud_testutils python27Packages.kubernetes python27Packages.tensorflow-tensorboard python37Packages.goobook python37Packages.google-auth-httplib2 python37Packages.google-auth-oauthlib python37Packages.google_api_core python37Packages.google_api_python_client python37Packages.google_auth python37Packages.google_cloud_asset python37Packages.google_cloud_automl python37Packages.google_cloud_bigquery_datatransfer python37Packages.google_cloud_bigtable python37Packages.google_cloud_container python37Packages.google_cloud_core python37Packages.google_cloud_dataproc python37Packages.google_cloud_datastore python37Packages.google_cloud_dlp python37Packages.google_cloud_dns python37Packages.google_cloud_error_reporting python37Packages.google_cloud_firestore python37Packages.google_cloud_iot python37Packages.google_cloud_kms python37Packages.google_cloud_language python37Packages.google_cloud_logging python37Packages.google_cloud_monitoring python37Packages.google_cloud_pubsub python37Packages.google_cloud_redis python37Packages.google_cloud_resource_manager python37Packages.google_cloud_runtimeconfig python37Packages.google_cloud_securitycenter python37Packages.google_cloud_spanner python37Packages.google_cloud_speech python37Packages.google_cloud_storage python37Packages.google_cloud_tasks python37Packages.google_cloud_testutils python37Packages.google_cloud_texttospeech python37Packages.google_cloud_trace python37Packages.google_cloud_translate python37Packages.google_cloud_videointelligence python37Packages.google_cloud_vision python37Packages.google_cloud_websecurityscanner python37Packages.kubernetes python37Packages.pydrive python37Packages.pytorch python37Packages.tensorflow-bin python37Packages.tensorflow-tensorboard python37Packages.weboob python38Packages.beancount python38Packages.goobook python38Packages.google-auth-httplib2 python38Packages.google-auth-oauthlib python38Packages.google_api_core python38Packages.google_api_python_client python38Packages.google_auth python38Packages.google_cloud_asset python38Packages.google_cloud_automl python38Packages.google_cloud_bigquery_datatransfer python38Packages.google_cloud_bigtable python38Packages.google_cloud_container python38Packages.google_cloud_core python38Packages.google_cloud_dataproc python38Packages.google_cloud_datastore python38Packages.google_cloud_dlp python38Packages.google_cloud_dns python38Packages.google_cloud_error_reporting python38Packages.google_cloud_firestore python38Packages.google_cloud_iot python38Packages.google_cloud_kms python38Packages.google_cloud_language python38Packages.google_cloud_logging python38Packages.google_cloud_monitoring python38Packages.google_cloud_pubsub python38Packages.google_cloud_redis python38Packages.google_cloud_resource_manager python38Packages.google_cloud_runtimeconfig python38Packages.google_cloud_securitycenter python38Packages.google_cloud_spanner python38Packages.google_cloud_speech python38Packages.google_cloud_storage python38Packages.google_cloud_tasks python38Packages.google_cloud_testutils python38Packages.google_cloud_texttospeech python38Packages.google_cloud_trace python38Packages.google_cloud_translate python38Packages.google_cloud_videointelligence python38Packages.google_cloud_vision python38Packages.google_cloud_websecurityscanner python38Packages.kubernetes python38Packages.pydrive python38Packages.tensorflow-tensorboard python38Packages.weboob s3ql

this may have broken 1 package, but it fixes many others

@jonringer jonringer merged commit c691535 into NixOS:master Mar 19, 2020
@jonringer jonringer deleted the fix-google branch March 19, 2020 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@costrouc costrouc Awaiting requested review from costrouc

@terlar terlar Awaiting requested review from terlar

@lsix lsix Awaiting requested review from lsix

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonringer