Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/nextcloud: avoid loading imagick extension more than once #80849

Merged
merged 1 commit into from Feb 26, 2020
Merged

nixos/nextcloud: avoid loading imagick extension more than once #80849

merged 1 commit into from Feb 26, 2020

Conversation

BBBSnowball
Copy link
Contributor

Motivation for this change

Part of the PHP configuration is duplicated because the contents of the variable phpOptionsExtensions is already part of phpOptionsStr.

This causes lots of errors and warnings like the following:

Module 'imagick' already loaded at Unknown#0
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@BBBSnowball
nixos/nextcloud: avoid loading imagick extension more than once
db32158 
This avoids the following error message:
  Module 'imagick' already loaded at Unknown#0
@Ma27 Ma27 requested a review from aanderse February 25, 2020 20:10
@aanderse
Copy link
Member

aanderse commented Feb 26, 2020 •
edited

@GrahamcOfBorg test nextcloud

aanderse
aanderse approved these changes Feb 26, 2020
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is good 👍

@aanderse aanderse merged commit 4d67db3 into NixOS:master Feb 26, 2020
@Ekleog
Copy link
Member

Ekleog commented Apr 1, 2020

Backported as 2bdd1f3 ; as the issue also showed up on 20.03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@aanderse aanderse aanderse approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@BBBSnowball @aanderse @Ekleog @Ma27 @Janik-Haag