Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xv: 0.1.1 -> 0.1.2, rename to xxv #80853

Merged
merged 1 commit into from Feb 28, 2020
Merged

xv: 0.1.1 -> 0.1.2, rename to xxv #80853

merged 1 commit into from Feb 28, 2020

Conversation

lilyball
Copy link
Member

Motivation for this change

https://github.com/chrisvest/xxv/releases/tag/0.1.2

The xv tool was renamed to xxv and the license was updated.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lilyball
xv: 0.1.1 -> 0.1.2, rename to xxv
ce67af3 
Also update the license.
@bhipple
Copy link
Contributor

bhipple commented Feb 23, 2020 •
edited

Nice, this will also fix its Repology metadata getting confused with a different xv for the nixpkgs-update bumps!

https://repology.org/project/xv/versions

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/104

jonringer
jonringer approved these changes Feb 28, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
shows usage

[4 built, 1 copied, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/80853
1 package built:
xxv

@jonringer
Copy link
Contributor

@GrahamcOfBorg build xxv

@jonringer jonringer merged commit 18007d5 into NixOS:master Feb 28, 2020
@lilyball lilyball deleted the xxv branch February 28, 2020 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lilyball @bhipple @nixos-discourse @jonringer