Skip to content

nixos/security/pam: Add nodelay option #80896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2020
Merged

nixos/security/pam: Add nodelay option #80896

merged 1 commit into from
Apr 28, 2020
+10 −2

Conversation

clkamp
Copy link
Contributor

@clkamp clkamp commented Feb 23, 2020

Motivation for this change

Closes #65551

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Feb 23, 2020
@clkamp clkamp requested a review from prusnak February 23, 2020 14:18
@clkamp clkamp force-pushed the pam-unix-add-nodelay branch from 86709c4 to dc1efa9 Compare February 24, 2020 11:38
@clkamp clkamp requested a review from worldofpeace February 24, 2020 11:40
@aanderse
Copy link
Member

(triage) are we good to merge this?

@worldofpeace worldofpeace merged commit a0ebabf into NixOS:master Apr 28, 2020
flokli
flokli reviewed Apr 28, 2020
View reviewed changes
nixos/modules/security/pam.nix
default = false;
type = types.bool;
description = ''
Wheather the delay after typing a wrong password should be disabled.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

       Whether the delay after typing a wrong password should be disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli

@prusnak prusnak

@worldofpeace worldofpeace

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PAM nodelay option
4 participants
@clkamp @aanderse @flokli @worldofpeace