Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pysaml2: fix tests on 32bit systems #80895

Merged
merged 1 commit into from Feb 24, 2020
Merged

pythonPackages.pysaml2: fix tests on 32bit systems #80895

merged 1 commit into from Feb 24, 2020

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Feb 23, 2020

Motivation for this change

ZHF: #80379

Things done
  • Tested using sandboxing (nix.useSandbox)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested on i686, x86_64
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Feb 23, 2020

@GrahamcOfBorg build python3Packages.pysaml2 pkgsi686Linux.python3Packages.pysaml2

jonringer
jonringer approved these changes Feb 23, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
no regressions on x86

[5 built, 2 copied (37.2 MiB), 3.7 MiB DL]
https://github.com/NixOS/nixpkgs/pull/80895
3 package built:
matrix-synapse python37Packages.pysaml2 python38Packages.pysaml2

@jonringer
Copy link
Contributor

@GrahamcOfBorg build matrix-synapse python37Packages.pysaml2 python38Packages.pysaml2

@rnhmjoj rnhmjoj merged commit 1ded257 into NixOS:master Feb 24, 2020
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Feb 24, 2020

Backported: b4db2d9

@rnhmjoj rnhmjoj deleted the pysaml2 branch April 7, 2020 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rnhmjoj @jonringer