Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rl-2003: mention python driver #80848

Merged
merged 1 commit into from Apr 7, 2020

Conversation

worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Feb 23, 2020

Motivation for this change

Trying to cover #72828 #79335 and the plans for removal on the perl driver.

Don't merge just yet, because I need a hand with calculating how many tests were ported in 20.03.
(ref the [how_many_tests_were_ported] placeholder).

  • figure how many tests were ported in 20.03

cc @tfc

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

a transitory period to rewrite their tests to use the Python implementation. Users of the Perl driver will see
this warning everytime they use it:
<screen>
<prompt>$ </prompt>warning: Perl VM tests are deprecated and will be removed for 20.09.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is weird, why is there an output after propmt?

Please update your tests to use the python test driver.
See https://github.com/NixOS/nixpkgs/pull/71684 for details.
</screen>
API compatibility is planned to be kept for at least the next release.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API compatibility of what?

<listitem>
<para>
The testing driver implementation in NixOS is now in Python <filename>make-test-python.nix</filename>.
This was done by Jacek Galowicz <link xlink:href="https://github.com/tfc">(@tfc)</link>, and with the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This was done by Jacek Galowicz <link xlink:href="https://github.com/tfc">(@tfc)</link>, and with the
This was done by Jacek Galowicz (<link xlink:href="https://github.com/tfc">@tfc</link>), and with the

<para>
The testing driver implementation in NixOS is now in Python <filename>make-test-python.nix</filename>.
This was done by Jacek Galowicz <link xlink:href="https://github.com/tfc">(@tfc)</link>, and with the
collaboration of Julian Stecklina <link xlink:href="https://github.com/blitz">(@blitz)</link> and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
collaboration of Julian Stecklina <link xlink:href="https://github.com/blitz">(@blitz)</link> and
collaboration of Julian Stecklina (<link xlink:href="https://github.com/blitz">@blitz</link>) and

The testing driver implementation in NixOS is now in Python <filename>make-test-python.nix</filename>.
This was done by Jacek Galowicz <link xlink:href="https://github.com/tfc">(@tfc)</link>, and with the
collaboration of Julian Stecklina <link xlink:href="https://github.com/blitz">(@blitz)</link> and
Jana Traue <link xlink:href="https://github.com/jtraue">@jtraue</link>. All documentation has been updated to use this
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Jana Traue <link xlink:href="https://github.com/jtraue">@jtraue</link>. All documentation has been updated to use this
Jana Traue (<link xlink:href="https://github.com/jtraue">@jtraue</link>). All documentation has been updated to use this

This was done by Jacek Galowicz <link xlink:href="https://github.com/tfc">(@tfc)</link>, and with the
collaboration of Julian Stecklina <link xlink:href="https://github.com/blitz">(@blitz)</link> and
Jana Traue <link xlink:href="https://github.com/jtraue">@jtraue</link>. All documentation has been updated to use this
testing driver, and a total of [how_many_tests_were_ported] were ported. In 20.09 the Perl driver implementation,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not we want one more buffer release?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it was agreed widely that 20.09 was when it was going to be removed.
If anyone really needs it after that, or they having interest in the driver, they need to communicate this. The community has no incentive to keep it past 6 more months.

@jtojnar
Copy link
Contributor

jtojnar commented Feb 25, 2020

$ git log --oneline -G'test(ing)?-python.nix' upstream/release-19.09..upstream/release-20.03
b6551f4ca57 nixos/nixos-build-vms: switch to python test-driver
ae03096e500 nixos/tests/firefox: support running the test with the firefox ESR version
7684537e333 nixos/sanoid, nixos/syncoid: init module and test
d3efeb79b70 nixosTest: update to make-test-python.nix
13f7b755532 nixos/grocy: init module
097ab90850d nixos/sympa: init module
3bb2941e73d nixosTests.zfs: Refactor
059845b11de nixosTests.installer: Port to python
42adda1ec48 nixos/tests/restic.nix: add test
2e7d406b11d nixosTests.chromium: Port to Python
bc7444384f5 nixosTests.printing: Port to Python
5ae9820ea4f nixosTests.keymap: Port to python
8f6f418e424 nixosTests.ihatemoney: Port to python
afc3d258249 nixosTests.buildbot: Port to python
f350a6f42ce nixosTests.misc: port to python
36d1141acd2 nixosTests.networkingProxy: port to Python
9888b30924d nixosTests.gnome3: port to python
0a43e431ca8 nixos/freeswitch: init
4b7d28b0f99 victoriametrics: add module, tests
ee2acd6c6c6 nixosTests.proxy: Port to python
4df1df986d4 nixosTests.limesurvey: Port to python
a0fd819a4a4 nixos/networkd: add test for VRF configurations
8bab2dec10d nixos/dokuwiki: init module at 2018-04-22b
2c9bff9f6ff nixosTests.systemd: port to Python
a208e6eb994 nixosTests.buildkite: add test
5089214a3df nixos/corerad: init
900e288d223 Enable elasticsearch-curator on elasticsearch 7
78aec9cfcb1 nixosTests.xandikos: init
abebf8cdb3c nixosTests.initdb: Move code to existing postgres test
25b75b8fb58 nixosTests.home-assistant: port to python
f7b274d9571 nixosTests.kafka: port to python
8ecd07f9e3b nixosTests.elk: port to python
c44331dd5d5 nixosTests.initdb: port to python
9980eb87347 nixosTests.3proxy: port test to python
ab63902d1f4 nixosTests.haka: port to python
cb38bf33e7f nagios: add nixos test
ccf55bead1f nginx: Clear Last-Modified if ETag is from store
ad339ad4455 nixosTests.graphite: port to python.
12e35035f66 nixosTests.kexec: port to python.
1c2781d39c9 nixosTests.nginx*: port to python
c6a032ecf6a nixosTests.mumble: port to python
b72661749bb nixos/python-test-driver: add an option to disable python linter
7675c0b2a98 nixos/tests/hydra: port to python
aadfcc0900b nixos/keepalived: add test
228818c61f1 nixosTests.gnome3-xorg: port to python/rewrite
82f038d4686 trilium-server: Add module
25503db8e84 nixos/spacecookie: add service module and test
98d562f0b34 nixosTests.networking: Port tests to python
05587aba8b0 nixosTests.hitch: Port tests to python
5cb7b2cf60a nixosTests.hadoop.yarn: Port tests to python
563eea492b1 nixosTests.hadoop.hdfs: Port tests to python
a6ac3fd89fb nixosTests.initrd-network: Port tests to python
9fbb427f679 nixosTests.haproxy: Port tests to python
0de0b6a2815 nixosTests.leaps: Port tests to python
40ed6896e36 nixosTests.lidarr: Port tests to python
1f2030fdcb2 nixosTests.mailcatcher: Port tests to python
23d164edb49 nixosTests.wireguard.namespaces: Port test to python
229a0afb28b nixosTests.paperless: Port tests to python
d76ab647e67 nixosTests.pdns-recursor: Port tests not python
d58814ac5a3 nixosTests.peerflix: Port tests to python
a20683acbef nixosTests.pgmanage: Port tests to python
1bf1ec35bca nixosTests.php-pcre: Port tests to python
d029e28b78e nixosTests.postgis: Port tests to python
e96802ccb22 nixosTests.quagga: Port tests to python
c811e76d828 nixosTests.mutable-users: Port tests to python
58cd46ba218 nixosTests.mxisd: Port tests to python
8c683b3b137 nixosTests.nesting: Port tests to python
e51673bb77d nixosTests.nghttpx: Port tests to python
1f3f9fd3a2f nixosTests.novacomd: Port tests to python
065770607e6 nixosTests.nzbget: Port tests to python
57e8bd9ebea nixosTest.orangefs: Port tests to python
862a7393f35 nixosTests.osrm-backend: Port tests to python
5ae92144ba0 nixosTests.overlayfs: Port tests to python
bcf6aa5519c nixosTests.sonarr: Port tests to python
aeeabe0b89d nixosTests.switch-test: Port tests to python
69b1b0cff05 nixosTests.systemd-timesyncd: Port tests to python
c98d54a3e9f zsh-history: Add tests
0dce66a6ec4 nixos/nfs: test nfs with kerberos authentication
59a0e58576c nixos/nfs: convert test to python
76a602dde4a nixosTests.rspamd: port to python
e3654540667 nixos/tests: add systemd-analyze test
ead22d14155 nixosTests.ipv6: port to python
6fbb76cf766 nixosTests.containers*: port rest to python
9314dc43b3d gitolite: wrap gitolite-shell
6b1faaf6845 nixosTests.pam-u2f: port test to python
7e25be92b71 nixosTests.env: Port to Python
46fab2e289b nixosTests.ecryptfs: Port to Python
4a7ba2cdfe6 nixosTests.docker-tools-overlay: Port to Python
86a9d80b45a nixosTests.dhparams: Port to Python
dfa7042eaf9 nixosTests.consul: init
2cda20c12ee nixos/tests/munin: port to python
07be5808892 nixos/tests/timezone: port to python
5d91b29e0d6 nixosTests.openldap: port test to python
15f105d41fb nixosTests.ldap: port integration test to python
c37902dfd19 nixosTests.gvisor: add test for gvisor and gvisor as a Docker runtime
b6d5e3844f7 nixos/tests/i3wm: port to python
a16695578b3 nixos/pam-oath-login: Port test to python
2ad9a627de9 nixos/tests/tiddlywiki: port to python
f8218178f7e nixosTests.gocd-server: port to python
46daafa269b nixosTest.gocd-agent: port to python
362e3771543 nixos/tests/xrdp: port to python
0168f41d70a nixosTests.moinmoin: port to python
8d6bcf80a20 nixosTests.predictable-interface-names: python
be911515eb3 nixosTests.radicale: port to python
268062198d1 nixosTests.mediawiki: port to python
8f6bea4ae9b nixosTests.openarena: port to python
1a5d3070ac8 nixosTests.matomo: port to python
33ab6997cdc nixosTests.nat: port to python
918c2ca01aa Remove networking.hostConf option
085766fd63c nixosTests.netdata: port to python
189a345e223 nixos/ferm: port test to python
a9a271792d5 nixos/ndppd: port test to python test-driver
af0f948c9e9 nixosTests.memcached: port to python
6225fc5303b nixos/nextcloud: port tests to python test-driver
9de0a8a7b3d nixos/containers-imperative: Port test to python
07802f4d204 nixos/containers-ip: Test both ipv4 and ipv6 in the same script
a610202cb63 nixosTests.kernel-*: port to python
88a40abc92e nixos/iftop: port test to python test-driver
696b44013ee nixos/xss-lock: port test to python test-driver
4e89f75ca69 nixos/containers-bridge: Port test to python
76605b21272 nixos/ejabberd: Port test to python
ab374b30563 nixos/containers-tmpfs: Port test to python
da39d2be5a9 nixos/containers-reloadable: Port test to python
e4abed35be7 nixos/containers-hosts: Port test to python
acb53c777c4 nixos/containers-ephemeral: Port test to python
e15c4e48a21 nixosTests.pantheon: port to python
e4962aa6a7e nixosTests.plasma5: drop sddm ocr theme
f5746f9c0b8 nixosTests.riak: port to python
248a3de9485 nixosTests.rabbitmq: port to python
7398211601c nixosTests.syncthing*: port to python
9a2c7caa43f nixos/nexus: port test to python test-driver
1043b55e4b5 nixosTests.sudo: port to python
dde45712a79 nixosTests.jenkins: port to python
aa5f701e880 nixosTests.influxdb: port to python
b86d62006da nixosTests.minio: port to python
84e32f6d9c9 nixosTests.gitolite: port to python
e6d71e498fd nixosTests.uwsgi: port to python
ca12e08caab nixosTests.bees: port to python
e20e12442eb nixos/prometheus: Port prometheus test to python
ec16d5c3ba6 nixosTests.wordpress: port to python
7ca619018f4 nixos/graylog: port test to python test-driver
a1e6e5145bd nixos/codimd: port test to python test-driver
2403c1a88d9 nixos/gotify-server: port test to python test-driver
3b218e85707 nixos/docker-registry: port test to python test-driver
433972d65b6 nixosTests.prosody*: port to python
3a38343576c nixosTests.glusterfs: port to python
6bd28271dcd nixosTests.etcd-cluster: port to python
39e8f9a3128 nixosTests.etcd: port to python
b118137d43d nixosTests.dovecot: port test to python
cfaaa524e3b nixosTests.google-oslogin: port to python
ba773444008 nixosTests.nix-ssh-serve: port to python
132b7032712 nixosTests.mysqlBackup: port to python
ced69719cd6 nixosTests.mysqlReplication: port to python
56718763e9e nixosTests.mysql: port to python
c47da6bd488 nixosTests.neo4j: port test to python
a8a552da536 nixosTests.systemd-nspawn: convert test to python
d28fd8f8dab nixos/kerberos: port tests to python
1d65113d418 nixosTests.gitlab: port to python
51217069517 nixosTests.mpd: port to python
86a947297a9 nixosTests.mongodb: port to python
bc1d542f095 nixos/miniflux: port test to python
32ef9dbfeaf nixos/jackett: port test to python
caa0cadaed9 nixos/minidlna: port test to python
1e70152489d nixos/incron: port test to python
35f16042a2e nixos/icingaweb2: port test to python
e4e1eea6257 nixos/handbrake: port test to python
98b28a776af nixos/hound: port test to python
66c99112640 nixos/hibernate: port test to python
c999eab3e78 nixos/fluentd: port test to python
a0a07e39360 nixos/fish: port test to python
541e2ca6d34 nixos/firewall: port test to python
05163ec981e nixos/clickhouse: port test to python
103f128dbb4 nixos/deluge: port test to python
e31441ba9ef nixos/fancontrol: port test to python
855eb6f264c nixos/mosquitto: Port integration test to python
6815017dcdf nixosTests.ceph-multi-node: port to python
a796dbead51 nixosTests.ceph-single-node: port to python
a72f8a36de8 nixosTests.xfce: port to python
fe12d5df42d tests/systemd-networkd-wireguard: migrate to `make-test-python`
f880347b173 nixosTests.rxe: port to python
f6a8eb2d00c nixos/tests/magnetico: port to python
45c1be7cae6 nixosTests.yggdrasil: port to python
ceccff3439f lorri: init at version unstable-2019-10-30
e7504615117 spike: init at 1.0.0
9b28dbd36a4 nixos/slurm: convert test from perl to python
4f2daa7b295 nixosTests.xmonad: port to python
b2fc25fe3c7 nixosTests.sddm: port to python
1132f037a1f nixosTests.lightdm: port to python
ece9c41343f nixos/samba: port test to python
40297480158 nixos/jellyfin: port test to python (#72828)
725168064df nixos/shiori: port test to python, do more tests
caac0964bbd nixos/tinydns: port test to python
b0e081549ea nixos/powerdns: port test to python
85bf23bb122 nixos/smokeping: port test to python
24b540d3ce5 nixos/pppd: port test to python
1c5bfddbc92 nixos/opensmtpd: convert test to python
25c25060951 nixos/cassandra: Port test to python
2c3785a6aeb nixos/docker-edge: port test to python
426b467af81 nixos/tests/prometheus-exporters: port to python
34755fb5e4d nixos/tests/grafana: port to python
9a7101c999a nixos/tests/initrd-ssh: port to python
336bffae6db nixos/tests/pgjwt: port to python
ff4e86f4a53 nixos/tests/loki: port to python
f04daa6f382 nixos/dnscrypt-proxy: port test to python
dd188ae2dcd nixos/couchdb: port test to python
bf816e44c4f nixos/documize: port test to python
e2c20c62303 nixos/docker: port test to python
3695e600cc9 nixos/cjdns: port test to python
30d1dfef4b9 nixos/cloud-init: port test to python
e05f546f3ac nixos/cfssl: port test to python
63cb143801e nixos/certmgr: port test to python
349c14f9502 nixos/cadvisor: port test to python
2f7199af213 nixos/caddy: port test to python
eee5986ac3c nixos/tests: add gnome-installed-tests with builder function
ceec19f682c nixosTests.udisks2: port to python
7d331eae2e7 nixosTests.packagekit: port to python
8920cbc8aab nixos/signal-desktop: port test to python
4ffdd43d2da nixos/rss2email: port test to python
71824d769c9 nixos/roundcube: port test to python
6868807c2ff nixos/redis: port test to python
9ca60eda5ac nixos/radarr: port test to python
af117c388b2 nixos/borgbackup: port test to python
54cc018b1ed nixos/boot-stage1: port test to python
44e6c84ea16 nixos/bind: port test to python
db546221456 nixos/beanstalkd: port test to python
f794de4e317 nixos/bcachefs: port test to python
0f96f9f038f nixos/avahi: port test to python
e86b9b9f084 nixos/atd: port test to python
3803abae68d nixos/snapper: port test to python
1b6ca29f6d0 nixos/strongswan-swanctl: port test to python
c0c04737ed6 nixos/telegraf: port test to python
8060e760374 nixos/xautolock: port test to python
6ea7ba4d691 nixos/moodle: port test to python
650ccb604b4 nixos/morty: port test to python
38b2e18faa5 nixos/upnp: port test to python
13febec4640 nixos/zookeeper: port test to python
49914d7d8b0 nixos/yabar: port test to python
274fb7e0b98 nixos/trickster: port test to python
5efe49ce673 nixosTests.fontconfig-default-fonts: port to python
23340a21b6e nixos/trezord: port test to python
5768950f019 nixos/trac: port test to python
6465a56d38f nixos/metabase: port test to python
d6b7a9909e7 nixos/firefox: Port integration test to python
fdb72f68ad5 nixos/matrix-synapse: Port integration test to python
5fecc35bb2e nixos/vault: convert test to python
76df6d67eac nixos/knot: port test to python
e13f4057e4a nixos/babeld: port test to python
50ea99cbc18 nixos/tests/quake3.nix: Remove
7d98a8ba77d nixos/simple: port test to python
16d2fccfd93 nixos/nix-generate-config: port test to python
1afa50aef1f nixos/fsck: port test to python
04f09616270 nixos/transmission: port test to python
daa97862b58 nixos/tor: port test to python
b786c1be046 nixos/openssh: port test to python
40396a7e124 nixos/zfs: convert test to python
48508da01e7 nixos/automysqlackup: Port test to python
986a1eb32b9 nixos/ammonite: Port test to python
e5ee5962630 nixos/acme: Port test to python
d4a5ea5219c nixos/boot: Port test to python
cdd4d4fadf0 nixos/wireguard: convert generated test to python
baec88a1199 nixos/wireguard: convert default test to python
8b12f0ddcc0 nixos/quake3: convert test to python
2af2d59fd61 nixos/emacs-daemon: convert test to python
9b33b5d38c3 nixos/gitea: convert test to python
8eead58520f nixos/postgres: Port test to python
75d3e810d68 nixos/bittorrent: Port test to python
be48c5c5714 nixos/login: Port test to python
7d19c5aaa76 nixos/test: Pythonify documentation
3a28fefe7d4 nixos/test: Port test driver to python

Edit: We should probably subtract these:

7684537e333 nixos/sanoid, nixos/syncoid: init module and test
13f7b755532 nixos/grocy: init module
097ab90850d nixos/sympa: init module
42adda1ec48 nixos/tests/restic.nix: add test
0a43e431ca8 nixos/freeswitch: init
4b7d28b0f99 victoriametrics: add module, tests
a0fd819a4a4 nixos/networkd: add test for VRF configurations
8bab2dec10d nixos/dokuwiki: init module at 2018-04-22b
5089214a3df nixos/corerad: init
900e288d223 Enable elasticsearch-curator on elasticsearch 7
78aec9cfcb1 nixosTests.xandikos: init
abebf8cdb3c nixosTests.initdb: Move code to existing postgres test
cb38bf33e7f nagios: add nixos test
ccf55bead1f nginx: Clear Last-Modified if ETag is from store
b72661749bb nixos/python-test-driver: add an option to disable python linter
aadfcc0900b nixos/keepalived: add test
82f038d4686 trilium-server: Add module
25503db8e84 nixos/spacecookie: add service module and test
c98d54a3e9f zsh-history: Add tests
0dce66a6ec4 nixos/nfs: test nfs with kerberos authentication
e3654540667 nixos/tests: add systemd-analyze test
9314dc43b3d gitolite: wrap gitolite-shell
dfa7042eaf9 nixosTests.consul: init
c37902dfd19 nixosTests.gvisor: add test for gvisor and gvisor as a Docker runtime
918c2ca01aa Remove networking.hostConf option
07802f4d204 nixos/containers-ip: Test both ipv4 and ipv6 in the same script
e4962aa6a7e nixosTests.plasma5: drop sddm ocr theme
ceccff3439f lorri: init at version unstable-2019-10-30
e7504615117 spike: init at 1.0.0
7d19c5aaa76 nixos/test: Pythonify documentation

@worldofpeace
Copy link
Contributor Author

I did this

❯ git log --oneline -G'test(ing)?-python.nix' upstream/release-19.09..upstream/release-20.03 | wc -l                                                
269

# put the suggested subtractions https://github.com/NixOS/nixpkgs/pull/80848#issuecomment-590720704 in a text file

❯ cat --plain extra.txt | wc -l    
30

269 - 30 = 239

Though looking back, I still see multiple commits on one certain test.
So I'd either have to manually look through it some more, or perhaps I can just get away with saying how many commits?

Please update your tests to use the python test driver.
See https://github.com/NixOS/nixpkgs/pull/71684 for details.
</screen>
API compatibility is planned to be kept for at least the next release with the perl driver.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this paragraph. I mean, most if not all of the functionality from the perl test driver were ported to the python tooling (which was a quite mechanical conversion).

We might want to keep some level of compatibility for the tests written that way, but I wouldn't call that API compatibility.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to change it 👍 I think it was a bit of a mistake on my part to claim that I should make this PR, when it turns out I'm becoming more over extended 🤣

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a new version. PTAL. Also, replaced the placeholder with a "hundreds of", because we don't need an exact number here.

@flokli
Copy link
Contributor

flokli commented Mar 3, 2020

Once merged, this would need to be forward-ported to master as well.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/go-no-go-meeting-nixos-20-03-markhor/6495/16

@worldofpeace
Copy link
Contributor Author

I did and a vast majority of the 286 tests in NixOS were ported to python driver.
Number was just from nix-build -A nixosTests.[tab completion]

@worldofpeace worldofpeace merged commit 29eddfc into NixOS:release-20.03 Apr 7, 2020
@worldofpeace worldofpeace deleted the 20.03-release-notes branch April 7, 2020 00:31
@worldofpeace
Copy link
Contributor Author

forward port 0594a76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants