Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimPlugins.vim-cue: init #80791

Merged
merged 2 commits into from Feb 22, 2020
Merged

vimPlugins.vim-cue: init #80791

merged 2 commits into from Feb 22, 2020

Conversation

eonpatapon
Copy link
Contributor

Motivation for this change

Added vim-cue plugin for cuelang.org

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from jorsn and jagajaga February 22, 2020 11:55
jonringer
jonringer approved these changes Feb 22, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commits LGTM

[76 built, 37 copied (665.2 MiB), 145.1 MiB DL]
https://github.com/NixOS/nixpkgs/pull/80791
39 package built:
vimPlugins.SpaceCamp vimPlugins.ale vimPlugins.bufexplorer vimPlugins.coc-git vimPlugins.coc-imselect vimPlugins.coc-metals vimPlugins.coc-python vimPlugins.coc-snippets vimPlugins.denite-git vimPlugins.denite-nvim vimPlugins.deoplete-fish vimPlugins.deoplete-khard vimPlugins.deoplete-nvim vimPlugins.fzf-vim vimPlugins.lh-vim-lib vimPlugins.neomake vimPlugins.nerdcommenter vimPlugins.nerdtree vimPlugins.nvim-lsp vimPlugins.open-browser-vim vimPlugins.swift-vim vimPlugins.tcomment_vim vimPlugins.tender-vim vimPlugins.vim-airline vimPlugins.vim-autoformat vimPlugins.vim-cue vimPlugins.vim-elixir vimPlugins.vim-fugitive vimPlugins.vim-go vimPlugins.vim-illuminate vimPlugins.vim-nftables vimPlugins.vim-snippets vimPlugins.vim-test vimPlugins.vim-textobj-user vimPlugins.vim-visual-multi vimPlugins.vimtex vimPlugins.vista-vim vimPlugins.yats-vim vimPlugins.youcompleteme

@jonringer jonringer merged commit 089d85b into NixOS:master Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@jorsn jorsn Awaiting requested review from jorsn

@jagajaga jagajaga Awaiting requested review from jagajaga

Assignees
No one assigned
Labels
6.topic: vim 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eonpatapon @jonringer