Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] Backport python.pkgs.pybullet: 2.6.1 -> 2.6.6 #80916

Merged
merged 1 commit into from Feb 24, 2020
Merged

[20.03] Backport python.pkgs.pybullet: 2.6.1 -> 2.6.6 #80916

merged 1 commit into from Feb 24, 2020

Conversation

mjlbach
Copy link
Contributor

@mjlbach mjlbach commented Feb 23, 2020

Motivation for this change

Cherry pick to fix pybullet in 20.03

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from timokau February 23, 2020 22:39
@timokau
Copy link
Member

timokau commented Feb 23, 2020

Please use git cherry-pick -x, which indicates in the commit message that this is a cherry-pick.

@mjlbach
python.pkgs.pybullet: 2.6.1 -> 2.6.6
caac051 
Update static-libs.patch

Add numpy to pybullet propagatedBuildInputs

Added numpy to build inputs

(cherry picked from commit c296c06)
@mjlbach
Copy link
Contributor Author

mjlbach commented Feb 24, 2020

@timokau fixed!

jonringer
jonringer approved these changes Feb 24, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
fixes build
commit LGTM

[4 built, 11 copied (94.7 MiB), 16.6 MiB DL]
https://github.com/NixOS/nixpkgs/pull/80916
3 package built:
python27Packages.pybullet python37Packages.pybullet python38Packages.pybullet

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python27Packages.pybullet python37Packages.pybullet python38Packages.pybullet

@jonringer jonringer merged commit 2eee73e into NixOS:release-20.03 Feb 24, 2020
@mjlbach mjlbach deleted the pybullet branch February 26, 2020 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@timokau timokau Awaiting requested review from timokau

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mjlbach @timokau @jonringer