Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meson: 0.52.1 -> 0.53.1 #80797

Merged
merged 1 commit into from Feb 28, 2020
Merged

meson: 0.52.1 -> 0.53.1 #80797

merged 1 commit into from Feb 28, 2020

Conversation

mpoquet
Copy link
Contributor

@mpoquet mpoquet commented Feb 22, 2020 •
edited

Motivation for this change

Keep meson up-to-date.
In particular, 0.52.1 caused annoying warnings about value duplication in compilation flags, which has been fixed upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from rasendubi February 22, 2020 12:54
@FRidh
Copy link
Member

FRidh commented Feb 22, 2020

This needs to target the staging branch.

@FRidh FRidh requested a review from jtojnar February 27, 2020 09:12
@FRidh FRidh added this to Needs review in Staging Feb 27, 2020
@jtojnar
Copy link
Contributor

jtojnar commented Feb 27, 2020

There is now 0.53.2. I reviewed the changes from 0.53.1 to 0.53.2 but did not yet get the time to read up on 0.52 to 0.53.

@jtojnar
Copy link
Contributor

jtojnar commented Feb 27, 2020

Release notes look okay, onto checking commits now.

@jtojnar
Copy link
Contributor

jtojnar commented Feb 27, 2020

Glanced over the commits, did not notice anything that potentially problematic.

Staging automation moved this from Needs review to Ready Feb 28, 2020
jtojnar
jtojnar approved these changes Feb 28, 2020
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully built and run GNOME VM, tried running various programs, nothing suspicious in logs.

@jtojnar jtojnar merged commit b0dfe1c into NixOS:master Feb 28, 2020
Staging automation moved this from Ready to Done Feb 28, 2020
@jtojnar
Copy link
Contributor

jtojnar commented Feb 28, 2020

Thanks.

@FRidh
Copy link
Member

FRidh commented Feb 28, 2020

into master?

@jtojnar
Copy link
Contributor

jtojnar commented Feb 28, 2020

Oops.

@jtojnar
Copy link
Contributor

jtojnar commented Feb 28, 2020

Reverted in ca55015 and pushed to staging as 65336dc. Thanks for pointing it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

@rasendubi rasendubi Awaiting requested review from rasendubi

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 2501-5000 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mpoquet @FRidh @jtojnar