Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.fluidasserts: disable because of dependency issues #80822

Closed
wants to merge 1 commit into from
Closed

pythonPackages.fluidasserts: disable because of dependency issues #80822

wants to merge 1 commit into from

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 22, 2020 •
edited

Motivation for this change
Their version bounds are too restrictive on packages
that get bumped too often. Making this package broken
constantly.

dependency concerns have been expressed for a while:
#78111
#78401
#79765
#78301
#79038
#79612

mostly want to avoid the noise of it on reviews

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Nothing changed
https://github.com/NixOS/nixpkgs/pull/80822
$ nix-shell /home/jon/.cache/nixpkgs-review/pr-80822/shell.nix

@jonringer
pythonPackages.fluidasserts: disable because of dependency issues
c917d19 
Their version bounds are too restrictive on packages
that get bumped too often. Making this package broken
constantly.
@jonringer
Copy link
Contributor Author

@kamadorueda fluidasserts could still live as an application. But I don't think it would work well as a python-package

@kamadorueda
Copy link
Member

@jonringer Please give it a look: #80828

I think this solves the underlaying problem (restrictive bounds)

@jonringer
Copy link
Contributor Author

superseded by #80828

@jonringer jonringer closed this Feb 23, 2020
@jonringer jonringer deleted the disable-fluidasserts branch February 23, 2020 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamadorueda kamadorueda Awaiting requested review from kamadorueda

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @kamadorueda