Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.chalice: disable pip version bounds #80821

Merged
merged 1 commit into from Feb 23, 2020
Merged

pythonPackages.chalice: disable pip version bounds #80821

merged 1 commit into from Feb 23, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 22, 2020 •
edited

Motivation for this change

to fix

on2.7/site-packages (from chalice==1.12.0) (7.0)
  ERROR: Could not find a version that satisfies the requirement pip<19.4,>=9 (from chalice==1.12.0) (from versions: none)
  ERROR: No matching distribution found for pip<19.4,>=9 (from chalice==1.12.0)

tests get ran, so versioning isn't a major concern

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
[4 built, 2 copied (0.2 MiB), 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/80821
4 package built:
python27Packages.PyLTI python27Packages.chalice python37Packages.chalice python38Packages.chalice

@jonringer
Copy link
Contributor Author

this doesn't need to be backported, as release isn't using pip>=20

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg python27Packages.PyLTI python27Packages.chalice python37Packages.chalice python38Packages.chalice

@ofborg ofborg bot requested a review from costrouc February 22, 2020 19:32
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python27Packages.PyLTI python27Packages.chalice python37Packages.chalice python38Packages.chalice

@jonringer jonringer merged commit 2c12bb3 into NixOS:master Feb 23, 2020
@jonringer jonringer deleted the fix-chalice branch February 26, 2020 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonringer