Add: [Actions] test if the repository builds successful #16
Conversation
| python -m pip install https://github.com/OpenTTD/nml/archive/master.zip | ||
| - name: Build | ||
| run: | | ||
| make Makefile.vcs Makefile.gfx |
There was a problem hiding this comment.
Why is this extra rule necessary? By my reading, they should be built by the standard make rules...
There was a problem hiding this comment.
Yeah ... current Makefile is a bit funky. It first includes these files, and later generates them. This gives both warnings, and wrong variable-values.
So a quick way to solve this is to generate them before running the rest.
Makefile needs some serious attention ;)
There was a problem hiding this comment.
I thought that including makefiles like that was fine - it should just do a file/rule check same as any other rule. What warnings are you seeing?
There was a problem hiding this comment.
Makefile:158: Makefile.vcs: No such file or directory
Makefile:256: Makefile.gfx: No such file or directory
I am sure it can be fixed one way or the other, but I rather first get this to work, and look into these details later. I will add a note how-ever, as that is currently missing.
TrueBrain
force-pushed
the
github_action2
branch
2 times, most recently
from
79d90f9
to
083f22c
Compare
TrueBrain
force-pushed
the
github_action2
branch
3 times, most recently
from
a083cca
to
5147d63
Compare
TrueBrain
force-pushed
the
github_action2
branch
from
5147d63
to
4e8fff4
Compare
No description provided.