programs/chromium: allow extensions outside chrome web store #80922
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The
programs.chromium.extensions
option currently appends the chrome web store update URL to the extension ID for the ExtensionInstallForcelist option. As indicated by the documentation for ExtensionInstallForcelist this is not necessary as it is already the default.Removing this implicit default would allow a user to more easily install extensions not in the chrome web store by setting the update URL themselves. An example was also added to the documentation.
If an alternative schema for this option is desired, I am open to it. Maybe a list of
{ id= "..."; updateURL = "..."; }
attrsets? I tried to just do a minimal change that wouldn't break any existing configs.Also relevant to this PR is #76863 which would be nicer but probably requires a lot more work.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)