Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go_1_12, go_1_13: remove velovix from maintainers #80918

Merged
merged 1 commit into from Feb 25, 2020
Merged

go_1_12, go_1_13: remove velovix from maintainers #80918

merged 1 commit into from Feb 25, 2020

Conversation

velovix
Copy link
Contributor

@velovix velovix commented Feb 23, 2020

Motivation for this change

When I originally added myself as a maintainer it seemed like there wasn't as much momentum behind Go on NixOS, but these days there are plenty of talented people making and approving PRs for Go. I don't have the expertise to maintain this package properly, but I sure am thankful for those of you that do!

Things done

I have removed myself as a maintainer for the Go packages.

I'm assuming that a change like this does not actually affect downstream packages so I haven't done any testing. Please correct me if I'm wrong and I'll do whatever's necessary.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants