pythonPackages.psutil: 5.6.7 -> 5.7.0 #80772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
6.topic: python
10.rebuild-darwin: 101-500
10.rebuild-linux: 101-500
labels
JeffLabonte
suggested changes
Feb 22, 2020
|
this needs testing on Hydra unless someone does all the rebuilds. |
true |
jonringer
force-pushed
the
bump-psutil
branch
from
94203a5
to
90b2d9f
Compare
|
a lot of the tests were platform specific, or shelled out to a multitude of other utilities. |
JeffLabonte
suggested changes
Feb 23, 2020
There was a problem hiding this comment.
It doesn't build in python 2.7. It requires mock to be installed for the tests.
==================================== ERRORS ====================================
_______________________ ERROR collecting test_system.py ________________________
ImportError while importing test module '/nix/store/gbc2846c47iwii1w57xpma8kyiyvkh8n-python2.7-psutil-5.7.0/lib/python2.7/site-packages/psutil/tests/test_system.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/nix/store/gbc2846c47iwii1w57xpma8kyiyvkh8n-python2.7-psutil-5.7.0/lib/python2.7/site-packages/psutil/tests/__init__.py:62: in <module>
import mock # NOQA - requires "pip install mock"
E ImportError: No module named mock
!!!!!!!!!!!!!!!!!!! Interrupted: 1 errors during collection !!!!!!!!!!!!!!!!!!!!
=========================== 1 error in 0.16 seconds ============================
jonringer
force-pushed
the
bump-psutil
branch
from
90b2d9f
to
2e74c4b
Compare
|
@GrahamcOfBorg build python3Packages.psutil pythonPackages.psutil python38Packages.psutil |
jonringer
force-pushed
the
bump-psutil
branch
from
2e74c4b
to
c4a9978
Compare
|
@GrahamcOfBorg build python3Packages.psutil pythonPackages.psutil python38Packages.psutil |
JeffLabonte
approved these changes
Feb 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
noticed it was out of date
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)